From 33a4466f767be8b153ef1ef78433ad9b1867dab8 Mon Sep 17 00:00:00 2001 From: Joe Conway Date: Sun, 9 Jun 2013 17:30:39 -0700 Subject: [PATCH] Fix ordering of obj id for Rules and EventTriggers in pg_dump. getSchemaData() must identify extension member objects and mark them as not to be dumped. This must happen after reading all objects that can be direct members of extensions, but before we begin to process table subsidiary objects. Both rules and event triggers were wrong in this regard. Backport rules portion of patch to 9.1 -- event triggers do not exist prior to 9.3. Suggested fix by Tom Lane, initial complaint and patch by me. --- src/bin/pg_dump/common.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/bin/pg_dump/common.c b/src/bin/pg_dump/common.c index ae52ac11ede..58322dc59a6 100644 --- a/src/bin/pg_dump/common.c +++ b/src/bin/pg_dump/common.c @@ -203,8 +203,8 @@ getSchemaData(Archive *fout, int *numTablesPtr) inhinfo = getInherits(fout, &numInherits); if (g_verbose) - write_msg(NULL, "reading rewrite rules\n"); - getRules(fout, &numRules); + write_msg(NULL, "reading event triggers\n"); + getEventTriggers(fout, &numEventTriggers); /* * Identify extension member objects and mark them as not to be dumped. @@ -241,8 +241,8 @@ getSchemaData(Archive *fout, int *numTablesPtr) getTriggers(fout, tblinfo, numTables); if (g_verbose) - write_msg(NULL, "reading event triggers\n"); - getEventTriggers(fout, &numEventTriggers); + write_msg(NULL, "reading rewrite rules\n"); + getRules(fout, &numRules); *numTablesPtr = numTables; return tblinfo;