database/postgres
database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-06-08 22:02:03 +03:00
Code

Doc: stop implying recommendation of insecure search_path value.

Browse Source 
SQL "SET search_path = 'pg_catalog, pg_temp'" is silently equivalent to
"SET search_path = pg_temp, pg_catalog, "pg_catalog, pg_temp"" instead
of the intended "SET search_path = pg_catalog, pg_temp".  (The intent
was a two-element search path.  With the single quotes, it instead
specifies one element with a comma and a space in the middle of the
element.)  In addition to the SET statement, this affects SET clauses of
CREATE FUNCTION, ALTER ROLE, and ALTER DATABASE.  It does not affect the
set_config() SQL function.

Though the documentation did not show an insecure command, remove single
quotes that could entice a reader to write an insecure command.
Back-patch to v13 (all supported versions).

Reported-by: Sven Klemm <sven@timescale.com>
Author: Sven Klemm <sven@timescale.com>
Backpatch-through: 13
This commit is contained in:
Noah Misch 2025-05-01 16:51:59 -07:00
parent e14df1015e
commit 334e508e17
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
doc/src/sgml/extend.sgml
View File

@ -1339,8 +1339,8 @@ SELECT * FROM pg_extension_update_paths('<replaceable>extension_name</replaceabl
secure <varname>search_path</varname>; do <emphasis>not</emphasis> secure <varname>search_path</varname>; do <emphasis>not</emphasis>
trust the path provided by <command>CREATE/ALTER EXTENSION</command> trust the path provided by <command>CREATE/ALTER EXTENSION</command>
to be secure. Best practice is to temporarily to be secure. Best practice is to temporarily
set <varname>search_path</varname> to <literal>'pg_catalog, set <varname>search_path</varname> to <literal>pg_catalog,
pg_temp'</literal> and insert references to the extension's pg_temp</literal> and insert references to the extension's
installation schema explicitly where needed. (This practice might installation schema explicitly where needed. (This practice might
also be helpful for creating views.) Examples can be found in also be helpful for creating views.) Examples can be found in
the <filename>contrib</filename> modules in the <filename>contrib</filename> modules in