database/postgres
database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-04-21 12:05:57 +03:00
Code

postgres_fdw: Remove useless DO block in test

Browse Source 
Discussion: https://www.postgresql.org/message-id/flat/b1f9f399-3a1a-b554-283f-4ae7f34608e2@enterprisedb.com
This commit is contained in:
Peter Eisentraut 2022-09-16 15:57:34 +02:00
parent 5ac51c8c9e
commit 32b507378f
2 changed files with 2 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
contrib/postgres_fdw/expected/postgres_fdw.out
View File

@ -9699,15 +9699,9 @@ ERROR: password is required
DETAIL: Non-superusers must provide a password in the user mapping. DETAIL: Non-superusers must provide a password in the user mapping.
-- If we add a password to the connstr it'll fail, because we don't allow passwords -- If we add a password to the connstr it'll fail, because we don't allow passwords
-- in connstrs only in user mappings. -- in connstrs only in user mappings.
DO $d$ ALTER SERVER loopback_nopw OPTIONS (ADD password 'dummypw');
BEGIN
EXECUTE $$ALTER SERVER loopback_nopw OPTIONS (ADD password 'dummypw')$$;
END;
$d$;
ERROR: invalid option "password" ERROR: invalid option "password"
HINT: Perhaps you meant the option "passfile". HINT: Perhaps you meant the option "passfile".
CONTEXT: SQL statement "ALTER SERVER loopback_nopw OPTIONS (ADD password 'dummypw')"
PL/pgSQL function inline_code_block line 3 at EXECUTE
-- If we add a password for our user mapping instead, we should get a different -- If we add a password for our user mapping instead, we should get a different
-- error because the password wasn't actually *used* when we run with trust auth. -- error because the password wasn't actually *used* when we run with trust auth.
-- --

6
contrib/postgres_fdw/sql/postgres_fdw.sql
View File

@ -2899,11 +2899,7 @@ SELECT 1 FROM ft1_nopw LIMIT 1;
-- If we add a password to the connstr it'll fail, because we don't allow passwords -- If we add a password to the connstr it'll fail, because we don't allow passwords
-- in connstrs only in user mappings. -- in connstrs only in user mappings.
DO $d$ ALTER SERVER loopback_nopw OPTIONS (ADD password 'dummypw');
BEGIN
EXECUTE $$ALTER SERVER loopback_nopw OPTIONS (ADD password 'dummypw')$$;
END;
$d$;
-- If we add a password for our user mapping instead, we should get a different -- If we add a password for our user mapping instead, we should get a different
-- error because the password wasn't actually *used* when we run with trust auth. -- error because the password wasn't actually *used* when we run with trust auth.