database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-10-19 15:49:24 +03:00
Code Activity

Put back intra-grant-inplace.spec test coverage

Browse Source 
Commit d31bbfb659 lost some test coverage, because the situation
being tested, a concurrent DROP, cannot happen anymore.  Put the test
coverage back with a bit of a trick, by deleting directly from the
catalog table.

Co-authored-by: Noah Misch <noah@leadboat.com>
Reviewed-by: Heikki Linnakangas <hlinnaka@iki.fi>
Discussion: https://www.postgresql.org/message-id/flat/bf72b82c-124d-4efa-a484-bb928e9494e4@eisentraut.org
This commit is contained in:
Peter Eisentraut
2025-08-27 16:47:23 +02:00
parent e36fa9319b
commit 310d04169a
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/test/isolation/expected/intra-grant-inplace.out
View File

@@ -226,7 +226,7 @@ step revoke4: <... completed>
starting permutation: b1 drop1 b3 sfu3 revoke4 c1 r3 starting permutation: b1 drop1 b3 sfu3 revoke4 c1 r3
step b1: BEGIN; step b1: BEGIN;
step drop1: step drop1:
DROP TABLE intra_grant_inplace; DELETE FROM pg_class WHERE relname = 'intra_grant_inplace';
step b3: BEGIN ISOLATION LEVEL READ COMMITTED; step b3: BEGIN ISOLATION LEVEL READ COMMITTED;
step sfu3: step sfu3:
@@ -248,6 +248,6 @@ relhasindex
----------- -----------
(0 rows) (0 rows)
s4: WARNING: got: relation "intra_grant_inplace" does not exist s4: WARNING: got: cache lookup failed for relation REDACTED
step revoke4: <... completed> step revoke4: <... completed>
step r3: ROLLBACK; step r3: ROLLBACK;

2
src/test/isolation/specs/intra-grant-inplace.spec
View File

@@ -20,7 +20,7 @@ step grant1 {
GRANT SELECT ON intra_grant_inplace TO PUBLIC; GRANT SELECT ON intra_grant_inplace TO PUBLIC;
} }
step drop1 { step drop1 {
DROP TABLE intra_grant_inplace; DELETE FROM pg_class WHERE relname = 'intra_grant_inplace';
} }
step c1 { COMMIT; } step c1 { COMMIT; }