database/postgres
database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-04-24 10:47:04 +03:00
Code

Fix comments in execGrouping.c

Browse Source 
Commit 5dfc1981 missed updating some comments.

Also, fix a comment typo found in passing.

Author: Jeff Davis
Discussion: https://postgr.es/m/9723131d247b919f94699152647fa87ee0bc02c2.camel%40j-davis.com
This commit is contained in:
Jeff Davis 2019-12-06 11:47:59 -08:00
parent fbbf68094c
commit 30d47723fd
2 changed files with 4 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/backend/executor/execGrouping.c
View File

@ -382,12 +382,9 @@ FindTupleHashEntry(TupleHashTable hashtable, TupleTableSlot *slot,
/* /*
* Compute the hash value for a tuple * Compute the hash value for a tuple
* *
* The passed-in key is a pointer to TupleHashEntryData. In an actual hash * If tuple is NULL, use the input slot instead. This convention avoids the
* table entry, the firstTuple field points to a tuple (in MinimalTuple * need to materialize virtual input tuples unless they actually need to get
* format). LookupTupleHashEntry sets up a dummy TupleHashEntryData with a * copied into the table.
* NULL firstTuple field --- that cues us to look at the inputslot instead.
* This convention avoids the need to materialize virtual input tuples unless
* they actually need to get copied into the table.
* *
* Also, the caller must select an appropriate memory context for running * Also, the caller must select an appropriate memory context for running
* the hash functions. (dynahash.c doesn't change CurrentMemoryContext.) * the hash functions. (dynahash.c doesn't change CurrentMemoryContext.)
@ -455,8 +452,6 @@ TupleHashTableHash(struct tuplehash_hash *tb, const MinimalTuple tuple)
/* /*
* See whether two tuples (presumably of the same hash value) match * See whether two tuples (presumably of the same hash value) match
*
* As above, the passed pointers are pointers to TupleHashEntryData.
*/ */
static int static int
TupleHashTableMatch(struct tuplehash_hash *tb, const MinimalTuple tuple1, const MinimalTuple tuple2) TupleHashTableMatch(struct tuplehash_hash *tb, const MinimalTuple tuple1, const MinimalTuple tuple2)

2
src/include/nodes/execnodes.h
View File

@ -2248,7 +2248,7 @@ typedef struct HashInstrumentation
int nbuckets_original; /* planned number of buckets */ int nbuckets_original; /* planned number of buckets */
int nbatch; /* number of batches at end of execution */ int nbatch; /* number of batches at end of execution */
int nbatch_original; /* planned number of batches */ int nbatch_original; /* planned number of batches */
size_t space_peak; /* speak memory usage in bytes */ size_t space_peak; /* peak memory usage in bytes */
} HashInstrumentation; } HashInstrumentation;
/* ---------------- /* ----------------