database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-06-17 17:02:08 +03:00
Code Activity

Fix timestamp in end-of-recovery WAL records.

Browse Source 
We used time(null) to set a TimestampTz field, which gave bogus results.
Noticed while looking at pg_xlogdump output.

Backpatch to 9.3 and above, where the fast promotion was introduced.
This commit is contained in:
Heikki Linnakangas
2014-12-19 17:00:21 +02:00
parent 4c853646ae
commit 306b9918b2
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/backend/access/transam/xlog.c
View File

@ -8408,7 +8408,7 @@ CreateEndOfRecoveryRecord(void)
if (!RecoveryInProgress()) if (!RecoveryInProgress())
elog(ERROR, "can only be used to end recovery"); elog(ERROR, "can only be used to end recovery");
xlrec.end_time = time(NULL); xlrec.end_time = GetCurrentTimestamp();
WALInsertLockAcquireExclusive(); WALInsertLockAcquireExclusive();
xlrec.ThisTimeLineID = ThisTimeLineID; xlrec.ThisTimeLineID = ThisTimeLineID;
@ -8433,7 +8433,7 @@ CreateEndOfRecoveryRecord(void)
* changes to this point. * changes to this point.
*/ */
LWLockAcquire(ControlFileLock, LW_EXCLUSIVE); LWLockAcquire(ControlFileLock, LW_EXCLUSIVE);
ControlFile->time = (pg_time_t) xlrec.end_time; ControlFile->time = (pg_time_t) time(NULL);
ControlFile->minRecoveryPoint = recptr; ControlFile->minRecoveryPoint = recptr;
ControlFile->minRecoveryPointTLI = ThisTimeLineID; ControlFile->minRecoveryPointTLI = ThisTimeLineID;
UpdateControlFile(); UpdateControlFile();