database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-06-13 07:41:39 +03:00
Code Activity

Improve performance of ExecEvalWholeRowVar.

Browse Source 
In commit b8d7f053c, we needed to fix ExecEvalWholeRowVar to not change
the state of the slot it's copying.  The initial quick hack at that
required two rounds of tuple construction, which is not very nice.
To fix, add another primitive to tuptoaster.c that does precisely what
we need.  (I initially tried to do this by refactoring one of the
existing functions into two pieces; but it looked like that might hurt
performance for the existing case, and the amount of code that could
be shared is not very large, so I gave up on that.)

Discussion: https://postgr.es/m/26088.1490315792@sss.pgh.pa.us
This commit is contained in:
Tom Lane
2017-03-26 19:14:47 -04:00
parent 895f93701f
commit 2f0903ea19
3 changed files with 90 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
src/backend/executor/execExprInterp.c
View File

@ -58,7 +58,7 @@
*/
#include "postgres.h"
#include "access/htup_details.h"
#include "access/tuptoaster.h"
#include "catalog/pg_type.h"
#include "executor/execExpr.h"
#include "executor/nodeSubplan.h"
@ -3508,24 +3508,24 @@ ExecEvalWholeRowVar(ExprState *state, ExprEvalStep *op, ExprContext *econtext)
}
/*
* Copy the slot tuple and make sure any toasted fields get detoasted.
* Build a composite datum, making sure any toasted fields get detoasted.
*
* (The intermediate copy is a tad annoying here, but we currently have no
* primitive that will do the right thing. Note it is critical that we
* not change the slot's state, so we can't use ExecFetchSlotTupleDatum.)
* (Note: it is critical that we not change the slot's state here.)
*/
tuple = ExecCopySlotTuple(slot);
dtuple = (HeapTupleHeader)
DatumGetPointer(heap_copy_tuple_as_datum(tuple,
slot->tts_tupleDescriptor));
heap_freetuple(tuple);
tuple = toast_build_flattened_tuple(slot->tts_tupleDescriptor,
slot->tts_values,
slot->tts_isnull);
dtuple = tuple->t_data;
/*
* Label the datum with the composite type info we identified before.
*
* (Note: we could skip doing this by passing op->d.wholerow.tupdesc to
* the tuple build step; but that seems a tad risky so let's not.)
*/
HeapTupleHeaderSetTypeId(dtuple, op->d.wholerow.tupdesc->tdtypeid);
HeapTupleHeaderSetTypMod(dtuple, op->d.wholerow.tupdesc->tdtypmod);
*op->resnull = false;
*op->resvalue = PointerGetDatum(dtuple);
*op->resnull = false;
}