database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-18 17:42:25 +03:00
Code Activity

Improve performance of ExecEvalWholeRowVar.

Browse Source 
In commit b8d7f053c, we needed to fix ExecEvalWholeRowVar to not change
the state of the slot it's copying.  The initial quick hack at that
required two rounds of tuple construction, which is not very nice.
To fix, add another primitive to tuptoaster.c that does precisely what
we need.  (I initially tried to do this by refactoring one of the
existing functions into two pieces; but it looked like that might hurt
performance for the existing case, and the amount of code that could
be shared is not very large, so I gave up on that.)

Discussion: https://postgr.es/m/26088.1490315792@sss.pgh.pa.us
This commit is contained in:
Tom Lane
2017-03-26 19:14:47 -04:00
parent 895f93701f
commit 2f0903ea19
3 changed files with 90 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

68
src/backend/access/heap/tuptoaster.c
View File

@ -1288,6 +1288,74 @@ toast_flatten_tuple_to_datum(HeapTupleHeader tup,
}
/* ----------
* toast_build_flattened_tuple -
*
* Build a tuple containing no out-of-line toasted fields.
* (This does not eliminate compressed or short-header datums.)
*
* This is essentially just like heap_form_tuple, except that it will
* expand any external-data pointers beforehand.
*
* It's not very clear whether it would be preferable to decompress
* in-line compressed datums while at it. For now, we don't.
* ----------
*/
HeapTuple
toast_build_flattened_tuple(TupleDesc tupleDesc,
Datum *values,
bool *isnull)
{
HeapTuple new_tuple;
Form_pg_attribute *att = tupleDesc->attrs;
int numAttrs = tupleDesc->natts;
int num_to_free;
int i;
Datum new_values[MaxTupleAttributeNumber];
Pointer freeable_values[MaxTupleAttributeNumber];
/*
* We can pass the caller's isnull array directly to heap_form_tuple, but
* we potentially need to modify the values array.
*/
Assert(numAttrs <= MaxTupleAttributeNumber);
memcpy(new_values, values, numAttrs * sizeof(Datum));
num_to_free = 0;
for (i = 0; i < numAttrs; i++)
{
/*
* Look at non-null varlena attributes
*/
if (!isnull[i] && att[i]->attlen == -1)
{
struct varlena *new_value;
new_value = (struct varlena *) DatumGetPointer(new_values[i]);
if (VARATT_IS_EXTERNAL(new_value))
{
new_value = heap_tuple_fetch_attr(new_value);
new_values[i] = PointerGetDatum(new_value);
freeable_values[num_to_free++] = (Pointer) new_value;
}
}
}
/*
* Form the reconfigured tuple.
*/
new_tuple = heap_form_tuple(tupleDesc, new_values, isnull);
/*
* Free allocated temp values
*/
for (i = 0; i < num_to_free; i++)
pfree(freeable_values[i]);
return new_tuple;
}
/* ----------
* toast_compress_datum -
*