database/postgres
database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-05-09 18:21:05 +03:00
Code

Use camel case for "DateStyle" in some error messages

Browse Source 
This GUC is written as camel-case in most of the documentation and the
GUC table (but not postgresql.conf.sample), and two error messages
hardcoded it with lower case characters.  Let's use a style more
consistent.

Most of the noise comes from the regression tests, updated to reflect
the GUC name in these error messages.

Author: Peter Smith
Reviewed-by: Peter Eisentraut, Álvaro Herrera
Discussion: https://postgr.es/m/CAHut+Pv-kSN8SkxSdoHano_wPubqcg5789ejhCDZAcLFceBR-w@mail.gmail.com
This commit is contained in:
Michael Paquier 2024-10-07 12:36:00 +09:00
parent f8d9a9f21e
commit 2e7c4abe5a
4 changed files with 32 additions and 32 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/backend/commands/variable.c
View File

@ -182,7 +182,7 @@ check_datestyle(char **newval, void **extra, GucSource source)
if (!ok) if (!ok)
{ {
GUC_check_errdetail("Conflicting \"datestyle\" specifications."); GUC_check_errdetail("Conflicting \"DateStyle\" specifications.");
return false; return false;
} }

2
src/backend/utils/adt/datetime.c
View File

@ -4107,7 +4107,7 @@ DateTimeParseError(int dterr, DateTimeErrorExtra *extra,
(errcode(ERRCODE_DATETIME_FIELD_OVERFLOW), (errcode(ERRCODE_DATETIME_FIELD_OVERFLOW),
errmsg("date/time field value out of range: \"%s\"", errmsg("date/time field value out of range: \"%s\"",
str), str),
errhint("Perhaps you need a different \"datestyle\" setting."))); errhint("Perhaps you need a different \"DateStyle\" setting.")));
break; break;
case DTERR_INTERVAL_OVERFLOW: case DTERR_INTERVAL_OVERFLOW:
errsave(escontext, errsave(escontext,

58
src/test/regress/expected/date.out
View File

@ -94,17 +94,17 @@ SELECT date '1/8/1999';
ERROR: date/time field value out of range: "1/8/1999" ERROR: date/time field value out of range: "1/8/1999"
LINE 1: SELECT date '1/8/1999'; LINE 1: SELECT date '1/8/1999';
^ ^
HINT: Perhaps you need a different "datestyle" setting. HINT: Perhaps you need a different "DateStyle" setting.
SELECT date '1/18/1999'; SELECT date '1/18/1999';
ERROR: date/time field value out of range: "1/18/1999" ERROR: date/time field value out of range: "1/18/1999"
LINE 1: SELECT date '1/18/1999'; LINE 1: SELECT date '1/18/1999';
^ ^
HINT: Perhaps you need a different "datestyle" setting. HINT: Perhaps you need a different "DateStyle" setting.
SELECT date '18/1/1999'; SELECT date '18/1/1999';
ERROR: date/time field value out of range: "18/1/1999" ERROR: date/time field value out of range: "18/1/1999"
LINE 1: SELECT date '18/1/1999'; LINE 1: SELECT date '18/1/1999';
^ ^
HINT: Perhaps you need a different "datestyle" setting. HINT: Perhaps you need a different "DateStyle" setting.
SELECT date '01/02/03'; SELECT date '01/02/03';
date date
------------ ------------
@ -139,7 +139,7 @@ SELECT date 'January 8, 99 BC';
ERROR: date/time field value out of range: "January 8, 99 BC" ERROR: date/time field value out of range: "January 8, 99 BC"
LINE 1: SELECT date 'January 8, 99 BC'; LINE 1: SELECT date 'January 8, 99 BC';
^ ^
HINT: Perhaps you need a different "datestyle" setting. HINT: Perhaps you need a different "DateStyle" setting.
SELECT date '99-Jan-08'; SELECT date '99-Jan-08';
date date
------------ ------------
@ -156,7 +156,7 @@ SELECT date '08-Jan-99';
ERROR: date/time field value out of range: "08-Jan-99" ERROR: date/time field value out of range: "08-Jan-99"
LINE 1: SELECT date '08-Jan-99'; LINE 1: SELECT date '08-Jan-99';
^ ^
HINT: Perhaps you need a different "datestyle" setting. HINT: Perhaps you need a different "DateStyle" setting.
SELECT date '08-Jan-1999'; SELECT date '08-Jan-1999';
date date
------------ ------------
@ -167,7 +167,7 @@ SELECT date 'Jan-08-99';
ERROR: date/time field value out of range: "Jan-08-99" ERROR: date/time field value out of range: "Jan-08-99"
LINE 1: SELECT date 'Jan-08-99'; LINE 1: SELECT date 'Jan-08-99';
^ ^
HINT: Perhaps you need a different "datestyle" setting. HINT: Perhaps you need a different "DateStyle" setting.
SELECT date 'Jan-08-1999'; SELECT date 'Jan-08-1999';
date date
------------ ------------
@ -198,7 +198,7 @@ SELECT date '08 Jan 99';
ERROR: date/time field value out of range: "08 Jan 99" ERROR: date/time field value out of range: "08 Jan 99"
LINE 1: SELECT date '08 Jan 99'; LINE 1: SELECT date '08 Jan 99';
^ ^
HINT: Perhaps you need a different "datestyle" setting. HINT: Perhaps you need a different "DateStyle" setting.
SELECT date '08 Jan 1999'; SELECT date '08 Jan 1999';
date date
------------ ------------
@ -209,7 +209,7 @@ SELECT date 'Jan 08 99';
ERROR: date/time field value out of range: "Jan 08 99" ERROR: date/time field value out of range: "Jan 08 99"
LINE 1: SELECT date 'Jan 08 99'; LINE 1: SELECT date 'Jan 08 99';
^ ^
HINT: Perhaps you need a different "datestyle" setting. HINT: Perhaps you need a different "DateStyle" setting.
SELECT date 'Jan 08 1999'; SELECT date 'Jan 08 1999';
date date
------------ ------------
@ -244,22 +244,22 @@ SELECT date '08-01-99';
ERROR: date/time field value out of range: "08-01-99" ERROR: date/time field value out of range: "08-01-99"
LINE 1: SELECT date '08-01-99'; LINE 1: SELECT date '08-01-99';
^ ^
HINT: Perhaps you need a different "datestyle" setting. HINT: Perhaps you need a different "DateStyle" setting.
SELECT date '08-01-1999'; SELECT date '08-01-1999';
ERROR: date/time field value out of range: "08-01-1999" ERROR: date/time field value out of range: "08-01-1999"
LINE 1: SELECT date '08-01-1999'; LINE 1: SELECT date '08-01-1999';
^ ^
HINT: Perhaps you need a different "datestyle" setting. HINT: Perhaps you need a different "DateStyle" setting.
SELECT date '01-08-99'; SELECT date '01-08-99';
ERROR: date/time field value out of range: "01-08-99" ERROR: date/time field value out of range: "01-08-99"
LINE 1: SELECT date '01-08-99'; LINE 1: SELECT date '01-08-99';
^ ^
HINT: Perhaps you need a different "datestyle" setting. HINT: Perhaps you need a different "DateStyle" setting.
SELECT date '01-08-1999'; SELECT date '01-08-1999';
ERROR: date/time field value out of range: "01-08-1999" ERROR: date/time field value out of range: "01-08-1999"
LINE 1: SELECT date '01-08-1999'; LINE 1: SELECT date '01-08-1999';
^ ^
HINT: Perhaps you need a different "datestyle" setting. HINT: Perhaps you need a different "DateStyle" setting.
SELECT date '99-08-01'; SELECT date '99-08-01';
date date
------------ ------------
@ -288,22 +288,22 @@ SELECT date '08 01 99';
ERROR: date/time field value out of range: "08 01 99" ERROR: date/time field value out of range: "08 01 99"
LINE 1: SELECT date '08 01 99'; LINE 1: SELECT date '08 01 99';
^ ^
HINT: Perhaps you need a different "datestyle" setting. HINT: Perhaps you need a different "DateStyle" setting.
SELECT date '08 01 1999'; SELECT date '08 01 1999';
ERROR: date/time field value out of range: "08 01 1999" ERROR: date/time field value out of range: "08 01 1999"
LINE 1: SELECT date '08 01 1999'; LINE 1: SELECT date '08 01 1999';
^ ^
HINT: Perhaps you need a different "datestyle" setting. HINT: Perhaps you need a different "DateStyle" setting.
SELECT date '01 08 99'; SELECT date '01 08 99';
ERROR: date/time field value out of range: "01 08 99" ERROR: date/time field value out of range: "01 08 99"
LINE 1: SELECT date '01 08 99'; LINE 1: SELECT date '01 08 99';
^ ^
HINT: Perhaps you need a different "datestyle" setting. HINT: Perhaps you need a different "DateStyle" setting.
SELECT date '01 08 1999'; SELECT date '01 08 1999';
ERROR: date/time field value out of range: "01 08 1999" ERROR: date/time field value out of range: "01 08 1999"
LINE 1: SELECT date '01 08 1999'; LINE 1: SELECT date '01 08 1999';
^ ^
HINT: Perhaps you need a different "datestyle" setting. HINT: Perhaps you need a different "DateStyle" setting.
SELECT date '99 08 01'; SELECT date '99 08 01';
date date
------------ ------------
@ -345,7 +345,7 @@ SELECT date '1/18/1999';
ERROR: date/time field value out of range: "1/18/1999" ERROR: date/time field value out of range: "1/18/1999"
LINE 1: SELECT date '1/18/1999'; LINE 1: SELECT date '1/18/1999';
^ ^
HINT: Perhaps you need a different "datestyle" setting. HINT: Perhaps you need a different "DateStyle" setting.
SELECT date '18/1/1999'; SELECT date '18/1/1999';
date date
------------ ------------
@ -392,7 +392,7 @@ SELECT date '99-Jan-08';
ERROR: date/time field value out of range: "99-Jan-08" ERROR: date/time field value out of range: "99-Jan-08"
LINE 1: SELECT date '99-Jan-08'; LINE 1: SELECT date '99-Jan-08';
^ ^
HINT: Perhaps you need a different "datestyle" setting. HINT: Perhaps you need a different "DateStyle" setting.
SELECT date '1999-Jan-08'; SELECT date '1999-Jan-08';
date date
------------ ------------
@ -435,7 +435,7 @@ SELECT date '99 Jan 08';
ERROR: date/time field value out of range: "99 Jan 08" ERROR: date/time field value out of range: "99 Jan 08"
LINE 1: SELECT date '99 Jan 08'; LINE 1: SELECT date '99 Jan 08';
^ ^
HINT: Perhaps you need a different "datestyle" setting. HINT: Perhaps you need a different "DateStyle" setting.
SELECT date '1999 Jan 08'; SELECT date '1999 Jan 08';
date date
------------ ------------
@ -480,7 +480,7 @@ SELECT date '99-01-08';
ERROR: date/time field value out of range: "99-01-08" ERROR: date/time field value out of range: "99-01-08"
LINE 1: SELECT date '99-01-08'; LINE 1: SELECT date '99-01-08';
^ ^
HINT: Perhaps you need a different "datestyle" setting. HINT: Perhaps you need a different "DateStyle" setting.
SELECT date '1999-01-08'; SELECT date '1999-01-08';
date date
------------ ------------
@ -515,7 +515,7 @@ SELECT date '99-08-01';
ERROR: date/time field value out of range: "99-08-01" ERROR: date/time field value out of range: "99-08-01"
LINE 1: SELECT date '99-08-01'; LINE 1: SELECT date '99-08-01';
^ ^
HINT: Perhaps you need a different "datestyle" setting. HINT: Perhaps you need a different "DateStyle" setting.
SELECT date '1999-08-01'; SELECT date '1999-08-01';
date date
------------ ------------
@ -526,7 +526,7 @@ SELECT date '99 01 08';
ERROR: date/time field value out of range: "99 01 08" ERROR: date/time field value out of range: "99 01 08"
LINE 1: SELECT date '99 01 08'; LINE 1: SELECT date '99 01 08';
^ ^
HINT: Perhaps you need a different "datestyle" setting. HINT: Perhaps you need a different "DateStyle" setting.
SELECT date '1999 01 08'; SELECT date '1999 01 08';
date date
------------ ------------
@ -561,7 +561,7 @@ SELECT date '99 08 01';
ERROR: date/time field value out of range: "99 08 01" ERROR: date/time field value out of range: "99 08 01"
LINE 1: SELECT date '99 08 01'; LINE 1: SELECT date '99 08 01';
^ ^
HINT: Perhaps you need a different "datestyle" setting. HINT: Perhaps you need a different "DateStyle" setting.
SELECT date '1999 08 01'; SELECT date '1999 08 01';
date date
------------ ------------
@ -603,7 +603,7 @@ SELECT date '18/1/1999';
ERROR: date/time field value out of range: "18/1/1999" ERROR: date/time field value out of range: "18/1/1999"
LINE 1: SELECT date '18/1/1999'; LINE 1: SELECT date '18/1/1999';
^ ^
HINT: Perhaps you need a different "datestyle" setting. HINT: Perhaps you need a different "DateStyle" setting.
SELECT date '01/02/03'; SELECT date '01/02/03';
date date
------------ ------------
@ -644,7 +644,7 @@ SELECT date '99-Jan-08';
ERROR: date/time field value out of range: "99-Jan-08" ERROR: date/time field value out of range: "99-Jan-08"
LINE 1: SELECT date '99-Jan-08'; LINE 1: SELECT date '99-Jan-08';
^ ^
HINT: Perhaps you need a different "datestyle" setting. HINT: Perhaps you need a different "DateStyle" setting.
SELECT date '1999-Jan-08'; SELECT date '1999-Jan-08';
date date
------------ ------------
@ -731,7 +731,7 @@ SELECT date '99-01-08';
ERROR: date/time field value out of range: "99-01-08" ERROR: date/time field value out of range: "99-01-08"
LINE 1: SELECT date '99-01-08'; LINE 1: SELECT date '99-01-08';
^ ^
HINT: Perhaps you need a different "datestyle" setting. HINT: Perhaps you need a different "DateStyle" setting.
SELECT date '1999-01-08'; SELECT date '1999-01-08';
date date
------------ ------------
@ -766,7 +766,7 @@ SELECT date '99-08-01';
ERROR: date/time field value out of range: "99-08-01" ERROR: date/time field value out of range: "99-08-01"
LINE 1: SELECT date '99-08-01'; LINE 1: SELECT date '99-08-01';
^ ^
HINT: Perhaps you need a different "datestyle" setting. HINT: Perhaps you need a different "DateStyle" setting.
SELECT date '1999-08-01'; SELECT date '1999-08-01';
date date
------------ ------------
@ -777,7 +777,7 @@ SELECT date '99 01 08';
ERROR: date/time field value out of range: "99 01 08" ERROR: date/time field value out of range: "99 01 08"
LINE 1: SELECT date '99 01 08'; LINE 1: SELECT date '99 01 08';
^ ^
HINT: Perhaps you need a different "datestyle" setting. HINT: Perhaps you need a different "DateStyle" setting.
SELECT date '1999 01 08'; SELECT date '1999 01 08';
date date
------------ ------------
@ -812,7 +812,7 @@ SELECT date '99 08 01';
ERROR: date/time field value out of range: "99 08 01" ERROR: date/time field value out of range: "99 08 01"
LINE 1: SELECT date '99 08 01'; LINE 1: SELECT date '99 08 01';
^ ^
HINT: Perhaps you need a different "datestyle" setting. HINT: Perhaps you need a different "DateStyle" setting.
SELECT date '1999 08 01'; SELECT date '1999 08 01';
date date
------------ ------------

2
src/test/regress/expected/horology.out
View File

@ -105,7 +105,7 @@ SELECT timestamp with time zone '27/12/2001 04:05:06.789-08';
ERROR: date/time field value out of range: "27/12/2001 04:05:06.789-08" ERROR: date/time field value out of range: "27/12/2001 04:05:06.789-08"
LINE 1: SELECT timestamp with time zone '27/12/2001 04:05:06.789-08'... LINE 1: SELECT timestamp with time zone '27/12/2001 04:05:06.789-08'...
^ ^
HINT: Perhaps you need a different "datestyle" setting. HINT: Perhaps you need a different "DateStyle" setting.
set datestyle to dmy; set datestyle to dmy;
SELECT timestamp with time zone '27/12/2001 04:05:06.789-08'; SELECT timestamp with time zone '27/12/2001 04:05:06.789-08';
timestamptz timestamptz