database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-12-07 12:02:30 +03:00
Code Activity

DROP AGGREGATE and COMMENT ON AGGREGATE now accept the expected syntax

Browse Source 
'aggname (aggtype)'.  The old syntax 'aggname aggtype' is still accepted
for backwards compatibility.  Fix pg_dump, which was actually broken for
most cases of user-defined aggregates.  Clean up error messages associated
with these commands.
This commit is contained in:
Tom Lane
2001-10-03 20:54:22 +00:00
parent 16def00ffb
commit 2e5fda7b7e
14 changed files with 137 additions and 157 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
src/test/regress/expected/errors.out
View File

@@ -129,21 +129,21 @@ ERROR: index "nonesuch" does not exist
-- missing aggregate name
drop aggregate;
ERROR: parser: parse error at or near ";"
-- bad aggregate name
drop aggregate 314159;
ERROR: parser: parse error at or near "314159"
-- no such aggregate
drop aggregate nonesuch;
ERROR: parser: parse error at or near ";"
-- missing aggregate type
drop aggregate newcnt1;
ERROR: parser: parse error at or near ";"
-- bad aggregate name
drop aggregate 314159 (int);
ERROR: parser: parse error at or near "314159"
-- bad aggregate type
drop aggregate newcnt nonesuch;
drop aggregate newcnt (nonesuch);
ERROR: RemoveAggregate: type 'nonesuch' does not exist
-- no such aggregate
drop aggregate nonesuch (int4);
ERROR: RemoveAggregate: aggregate 'nonesuch' for type integer does not exist
-- no such aggregate for type
drop aggregate newcnt float4;
ERROR: RemoveAggregate: aggregate 'newcnt' for 'float4' does not exist
drop aggregate newcnt (float4);
ERROR: RemoveAggregate: aggregate 'newcnt' for type real does not exist
--
-- REMOVE FUNCTION

6
src/test/regress/sql/drop.sql
View File

@@ -73,11 +73,11 @@ DROP TYPE widget;
--
-- AGGREGATE REMOVAL
--
DROP AGGREGATE newavg int4;
DROP AGGREGATE newavg (int4);
DROP AGGREGATE newsum int4;
DROP AGGREGATE newsum (int4);
DROP AGGREGATE newcnt int4;
DROP AGGREGATE newcnt (int4);
--

16
src/test/regress/sql/errors.sql
View File

@@ -147,20 +147,20 @@ drop index nonesuch;
-- missing aggregate name
drop aggregate;
-- bad aggregate name
drop aggregate 314159;
-- no such aggregate
drop aggregate nonesuch;
-- missing aggregate type
drop aggregate newcnt1;
-- bad aggregate name
drop aggregate 314159 (int);
-- bad aggregate type
drop aggregate newcnt nonesuch;
drop aggregate newcnt (nonesuch);
-- no such aggregate
drop aggregate nonesuch (int4);
-- no such aggregate for type
drop aggregate newcnt float4;
drop aggregate newcnt (float4);
--