mirror of
https://github.com/postgres/postgres.git
synced 2025-09-03 15:22:11 +03:00
Suppress warning about stack_base_ptr with late-model GCC.
GCC 12 complains that set_stack_base is storing the address of a local variable in a long-lived pointer. This is an entirely reasonable warning (indeed, it just helped us find a bug); but that behavior is intentional here. We can work around it by using __builtin_frame_address(0) instead of a specific local variable; that produces an address a dozen or so bytes different, in my testing, but we don't care about such a small difference. Maybe someday a compiler lacking that function will start to issue a similar warning, but we'll worry about that when it happens. Patch by me, per a suggestion from Andres Freund. Back-patch to v12, which is as far back as the patch will go without some pain. (Recently-established project policy would permit a back-patch as far as 9.2, but I'm disinclined to expend the work until GCC 12 is much more widespread.) Discussion: https://postgr.es/m/3773792.1645141467@sss.pgh.pa.us
This commit is contained in:
@@ -441,6 +441,7 @@ sub GenerateFiles
|
||||
HAVE__BUILTIN_CLZ => undef,
|
||||
HAVE__BUILTIN_CONSTANT_P => undef,
|
||||
HAVE__BUILTIN_CTZ => undef,
|
||||
HAVE__BUILTIN_FRAME_ADDRESS => undef,
|
||||
HAVE__BUILTIN_OP_OVERFLOW => undef,
|
||||
HAVE__BUILTIN_POPCOUNT => undef,
|
||||
HAVE__BUILTIN_TYPES_COMPATIBLE_P => undef,
|
||||
|
Reference in New Issue
Block a user