1
0
mirror of https://github.com/postgres/postgres.git synced 2025-04-29 13:56:47 +03:00

Add missing assign hook for GUC checkpoint_completion_target

This is wrong since 88e9823, that has switched the WAL sizing
configuration from checkpoint_segments to min_wal_size and
max_wal_size.  This missed the recalculation of the internal value of
the internal "CheckPointSegments", that works as a mapping of the old
GUC checkpoint_segments, on reload, for example, and it controls the
timing of checkpoints depending on the volume of WAL generated.

Most users tend to leave checkpoint_completion_target at 0.9 to smooth
the I/O workload, which is why I guess this has gone unnoticed for so
long, still it can be useful to tweak and reload the value dynamically
in some cases to control the timing of checkpoints.

Author: Bharath Rupireddy
Discussion: https://postgr.es/m/CALj2ACXgPPAm28mruojSBno+F_=9cTOOxHAywu_dfZPeBdybQw@mail.gmail.com
Backpatch-through: 11
This commit is contained in:
Michael Paquier 2023-01-19 13:13:28 +09:00
parent efd2474ab5
commit 2e21e2857e

View File

@ -3798,7 +3798,7 @@ static struct config_real ConfigureNamesReal[] =
}, },
&CheckPointCompletionTarget, &CheckPointCompletionTarget,
0.9, 0.0, 1.0, 0.9, 0.0, 1.0,
NULL, NULL, NULL NULL, assign_checkpoint_completion_target, NULL
}, },
{ {