From 2da896182ce11240774af6c4d769777f90a09536 Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Tue, 8 Feb 2022 15:40:08 -0500 Subject: [PATCH] Rename create_function_N test scripts for clarity. Rename create_function_0 to create_function_c, and create_function_3 to create_function_sql, to establish their charters more clearly. This should also reduce confusion versus our underscore-digit convention for naming variant expected-files. I separated this from the previous commit on the premise that keeping the renaming distinct might make "git blame" tracking easier. Discussion: https://postgr.es/m/1114748.1640383217@sss.pgh.pa.us --- .../expected/{create_function_0.out => create_function_c.out} | 2 +- .../{create_function_3.out => create_function_sql.out} | 2 +- src/test/regress/parallel_schedule | 4 ++-- .../sql/{create_function_0.sql => create_function_c.sql} | 2 +- .../sql/{create_function_3.sql => create_function_sql.sql} | 2 +- 5 files changed, 6 insertions(+), 6 deletions(-) rename src/test/regress/expected/{create_function_0.out => create_function_c.out} (98%) rename src/test/regress/expected/{create_function_3.out => create_function_sql.out} (99%) rename src/test/regress/sql/{create_function_0.sql => create_function_c.sql} (98%) rename src/test/regress/sql/{create_function_3.sql => create_function_sql.sql} (99%) diff --git a/src/test/regress/expected/create_function_0.out b/src/test/regress/expected/create_function_c.out similarity index 98% rename from src/test/regress/expected/create_function_0.out rename to src/test/regress/expected/create_function_c.out index ed674af971c..2dba9d70349 100644 --- a/src/test/regress/expected/create_function_0.out +++ b/src/test/regress/expected/create_function_c.out @@ -1,5 +1,5 @@ -- --- CREATE_FUNCTION_0 +-- CREATE_FUNCTION_C -- -- This script used to create C functions for other scripts to use. -- But to get rid of the ordering dependencies that caused, such diff --git a/src/test/regress/expected/create_function_3.out b/src/test/regress/expected/create_function_sql.out similarity index 99% rename from src/test/regress/expected/create_function_3.out rename to src/test/regress/expected/create_function_sql.out index 1e2dfd87d30..f9569554648 100644 --- a/src/test/regress/expected/create_function_3.out +++ b/src/test/regress/expected/create_function_sql.out @@ -1,5 +1,5 @@ -- --- CREATE FUNCTION +-- CREATE_FUNCTION_SQL -- -- Assorted tests using SQL-language functions -- diff --git a/src/test/regress/parallel_schedule b/src/test/regress/parallel_schedule index 82feda6eb18..6d8f524ae9e 100644 --- a/src/test/regress/parallel_schedule +++ b/src/test/regress/parallel_schedule @@ -47,13 +47,13 @@ test: copy copyselect copydml insert insert_conflict # More groups of parallel tests # Note: many of the tests in later groups depend on create_index # ---------- -test: create_function_0 create_misc create_operator create_procedure create_table create_type +test: create_function_c create_misc create_operator create_procedure create_table create_type test: create_index create_index_spgist create_view index_including index_including_gist # ---------- # Another group of parallel tests # ---------- -test: create_aggregate create_function_3 create_cast constraints triggers select inherit typed_table vacuum drop_if_exists updatable_views roleattributes create_am hash_func errors infinite_recurse +test: create_aggregate create_function_sql create_cast constraints triggers select inherit typed_table vacuum drop_if_exists updatable_views roleattributes create_am hash_func errors infinite_recurse # ---------- # sanity_check does a vacuum, affecting the sort order of SELECT * diff --git a/src/test/regress/sql/create_function_0.sql b/src/test/regress/sql/create_function_c.sql similarity index 98% rename from src/test/regress/sql/create_function_0.sql rename to src/test/regress/sql/create_function_c.sql index 54da95f2494..2e5a390a561 100644 --- a/src/test/regress/sql/create_function_0.sql +++ b/src/test/regress/sql/create_function_c.sql @@ -1,5 +1,5 @@ -- --- CREATE_FUNCTION_0 +-- CREATE_FUNCTION_C -- -- This script used to create C functions for other scripts to use. -- But to get rid of the ordering dependencies that caused, such diff --git a/src/test/regress/sql/create_function_3.sql b/src/test/regress/sql/create_function_sql.sql similarity index 99% rename from src/test/regress/sql/create_function_3.sql rename to src/test/regress/sql/create_function_sql.sql index 254f444d94d..4512456eae2 100644 --- a/src/test/regress/sql/create_function_3.sql +++ b/src/test/regress/sql/create_function_sql.sql @@ -1,5 +1,5 @@ -- --- CREATE FUNCTION +-- CREATE_FUNCTION_SQL -- -- Assorted tests using SQL-language functions --