database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-09-02 04:21:28 +03:00
Code Activity

Trivial dead code removal: in _complete_from_query(), 'text' cannot be

Browse Source 
NULL (e.g. due to the preceding strlen()). Therefore we needn't recheck
this before initializing 'e_text'.

Per Coverity static analysis performed by EnterpriseDB.
This commit is contained in:
Neil Conway
2005-06-21 00:48:33 +00:00
parent 141e878bc3
commit 2d4b9736bb
1 changed files with 4 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/bin/psql/tab-complete.c
View File

@@ -3,7 +3,7 @@
* *
* Copyright (c) 2000-2005, PostgreSQL Global Development Group * Copyright (c) 2000-2005, PostgreSQL Global Development Group
* *
* $PostgreSQL: pgsql/src/bin/psql/tab-complete.c,v 1.131 2005/06/14 17:43:14 momjian Exp $ * $PostgreSQL: pgsql/src/bin/psql/tab-complete.c,v 1.132 2005/06/21 00:48:33 neilc Exp $
*/ */
/*---------------------------------------------------------------------- /*----------------------------------------------------------------------
@@ -1909,13 +1909,8 @@ _complete_from_query(int is_schema_query, const char *text, int state)
result = NULL; result = NULL;
/* Set up suitably-escaped copies of textual inputs */ /* Set up suitably-escaped copies of textual inputs */
if (text) e_text = pg_malloc(string_length * 2 + 1);
{ PQescapeString(e_text, text, string_length);
e_text = pg_malloc(strlen(text) *2 + 1);
PQescapeString(e_text, text, strlen(text));
}
else
e_text = NULL;
if (completion_info_charp) if (completion_info_charp)
{ {
@@ -2035,9 +2030,7 @@ _complete_from_query(int is_schema_query, const char *text, int state)
result = exec_query(query_buffer.data); result = exec_query(query_buffer.data);
termPQExpBuffer(&query_buffer); termPQExpBuffer(&query_buffer);
free(e_text);
if (e_text)
free(e_text);
if (e_info_charp) if (e_info_charp)
free(e_info_charp); free(e_info_charp);
} }