database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-03 20:02:46 +03:00
Code Activity

Improve comments for row filtering and toast interaction in logical replication.

Browse Source 
Reported-by: Antonin Houska
Author: Amit Kapila
Reviewed-by: Antonin Houska, Ajin Cherian
Discussion: https://postgr.es/m/84638.1649152255@antos
This commit is contained in:
Amit Kapila
2022-04-06 08:20:40 +05:30
parent 17a856d08b
commit 2d09e44d30
1 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/backend/replication/pgoutput/pgoutput.c
View File

@ -1237,10 +1237,11 @@ pgoutput_row_filter(Relation relation, TupleTableSlot *old_slot,
* For inserts, we only have the new tuple. * For inserts, we only have the new tuple.
* *
* For updates, we can have only a new tuple when none of the replica * For updates, we can have only a new tuple when none of the replica
* identity columns changed but we still need to evaluate the row filter * identity columns changed and none of those columns have external data
* for new tuple as the existing values of those columns might not match * but we still need to evaluate the row filter for the new tuple as the
* the filter. Also, users can use constant expressions in the row filter, * existing values of those columns might not match the filter. Also, users
* so we anyway need to evaluate it for the new tuple. * can use constant expressions in the row filter, so we anyway need to
* evaluate it for the new tuple.
* *
* For deletes, we only have the old tuple. * For deletes, we only have the old tuple.
*/ */