database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-11-07 19:06:32 +03:00
Code Activity

BRIN: mask BRIN_EVACUATE_PAGE for WAL consistency checking

Browse Source 
That bit is unlogged and therefore it's wrong to consider it in WAL page
comparison.

Add a test that tickles the case, as branch testing technology allows.

This has been a problem ever since wal consistency checking was
introduced (commit a507b86900 for pg10), so backpatch to all supported
branches.

Author: 王海洋 (Haiyang Wang) <wanghaiyang.001@bytedance.com>
Reviewed-by: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Discussion: https://postgr.es/m/CACciXAD2UvLMOhc4jX9VvOKt7DtYLr3OYRBhvOZ-jRxtzc_7Jg@mail.gmail.com
Discussion: https://postgr.es/m/CACciXADOfErX9Bx0nzE_SkdfXr6Bbpo5R=v_B6MUTEYW4ya+cg@mail.gmail.com
This commit is contained in:
Alvaro Herrera
2022-08-05 18:00:17 +02:00
parent aa242501af
commit 2cff302590
4 changed files with 88 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/backend/access/brin/brin_xlog.c
View File

@@ -358,4 +358,10 @@ brin_mask(char *pagedata, BlockNumber blkno)
{
mask_unused_space(page);
}
/*
* BRIN_EVACUATE_PAGE is not WAL-logged, since it's of no use in recovery.
* Mask it. See brin_start_evacuating_page() for details.
*/
BrinPageFlags(page) &= ~BRIN_EVACUATE_PAGE;
}