database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-08-28 18:48:04 +03:00
Code Activity

Use printf's %m format instead of strerror(errno) in more places

Browse Source 
Most callers of strerror() are removed from the backend code.  The
remaining callers require special handling with a saved errno from a
previous system call.  The frontend code still needs strerror() where
error states need to be handled outside of fprintf.

Note that pg_regress is not changed to use %m as the TAP output may
clobber errno, since those functions call fprintf() and friends before
evaluating the format string.

Support for %m in src/port/snprintf.c has been added in d6c55de1f9,
hence all the stable branches currently supported include it.

Author: Dagfinn Ilmari Mannsåker
Discussion: https://postgr.es/m/87sf13jhuw.fsf@wibble.ilmari.org
This commit is contained in:
Michael Paquier
2024-03-12 10:02:54 +09:00
parent 3045324214
commit 2c8118ee5d
24 changed files with 158 additions and 192 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/interfaces/ecpg/preproc/ecpg.c
View File

@@ -216,8 +216,8 @@ main(int argc, char *const argv[])
if (base_yyout == NULL)
{
fprintf(stderr, _("%s: could not open file \"%s\": %s\n"),
progname, output_filename, strerror(errno));
fprintf(stderr, _("%s: could not open file \"%s\": %m\n"),
progname, output_filename);
output_filename = NULL;
}
else
@@ -331,8 +331,8 @@ main(int argc, char *const argv[])
base_yyout = fopen(output_filename, PG_BINARY_W);
if (base_yyout == NULL)
{
fprintf(stderr, _("%s: could not open file \"%s\": %s\n"),
progname, output_filename, strerror(errno));
fprintf(stderr, _("%s: could not open file \"%s\": %m\n"),
progname, output_filename);
free(output_filename);
output_filename = NULL;
free(input_filename);
@@ -342,8 +342,8 @@ main(int argc, char *const argv[])
}
if (base_yyin == NULL)
fprintf(stderr, _("%s: could not open file \"%s\": %s\n"),
progname, argv[fnr], strerror(errno));
fprintf(stderr, _("%s: could not open file \"%s\": %m\n"),
progname, argv[fnr]);
else
{
struct cursor *ptr;