database/postgres
database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-05-08 07:21:33 +03:00
Code

makeArrayTypeName: Remove pointless relation open/close

Browse Source 
Discussion: https://postgr.es/m/20191218221326.GA25537@alvherre.pgsql
This commit is contained in:
Alvaro Herrera 2019-12-19 12:08:30 -03:00
parent 54fbd155cc
commit 2b93e3d96b
1 changed files with 0 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/backend/catalog/pg_type.c
View File

@ -785,15 +785,12 @@ makeArrayTypeName(const char *typeName, Oid typeNamespace)
{ {
char *arr = (char *) palloc(NAMEDATALEN); char *arr = (char *) palloc(NAMEDATALEN);
int namelen = strlen(typeName); int namelen = strlen(typeName);
Relation pg_type_desc;
int i; int i;
/* /*
* The idea is to prepend underscores as needed until we make a name that * The idea is to prepend underscores as needed until we make a name that
* doesn't collide with anything... * doesn't collide with anything...
*/ */
pg_type_desc = table_open(TypeRelationId, AccessShareLock);
for (i = 1; i < NAMEDATALEN - 1; i++) for (i = 1; i < NAMEDATALEN - 1; i++)
{ {
arr[i - 1] = '_'; arr[i - 1] = '_';
@ -810,8 +807,6 @@ makeArrayTypeName(const char *typeName, Oid typeNamespace)
break; break;
} }
table_close(pg_type_desc, AccessShareLock);
if (i >= NAMEDATALEN - 1) if (i >= NAMEDATALEN - 1)
ereport(ERROR, ereport(ERROR,
(errcode(ERRCODE_DUPLICATE_OBJECT), (errcode(ERRCODE_DUPLICATE_OBJECT),