From 2ad3b9350f7338b9ba0327ccd307a0fbba2208dc Mon Sep 17 00:00:00 2001 From: Andres Freund Date: Mon, 15 Jul 2024 09:26:02 -0700 Subject: [PATCH] Fix type confusion in guc_var_compare() Before this change guc_var_compare() cast the input arguments to const struct config_generic *. That's not quite right however, as the input on one side is often just a char * on one side. Instead just use char *, the first field in config_generic. This fixes a -Warray-bounds warning with some versions of gcc. While the warning is only known to be triggered for <= 15, the issue the warning points out seems real, so apply the fix everywhere. Author: Nazir Bilal Yavuz Reported-by: Erik Rijkers Suggested-by: Andres Freund Discussion: https://postgr.es/m/a74a1a0d-0fd2-3649-5224-4f754e8f91aa%40xs4all.nl --- src/backend/utils/misc/guc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/backend/utils/misc/guc.c b/src/backend/utils/misc/guc.c index 04866078eb6..32d8aaea827 100644 --- a/src/backend/utils/misc/guc.c +++ b/src/backend/utils/misc/guc.c @@ -1252,10 +1252,10 @@ find_option(const char *name, bool create_placeholders, bool skip_errors, static int guc_var_compare(const void *a, const void *b) { - const struct config_generic *confa = *(struct config_generic *const *) a; - const struct config_generic *confb = *(struct config_generic *const *) b; + const char *namea = **(const char ** const *) a; + const char *nameb = **(const char ** const *) b; - return guc_name_compare(confa->name, confb->name); + return guc_name_compare(namea, nameb); } /*