From 2a6ce34b55e1cbb16a507c2e90c626eef71018b7 Mon Sep 17 00:00:00 2001 From: Michael Paquier Date: Sun, 18 Jan 2026 16:11:46 +0900 Subject: [PATCH] Remove useless asserts in report_namespace_conflict() An assertion is used in this routine to check that a valid namespace OID is given by the caller, but it was repeated twice: once at the top of the routine and a second time multiple times in a switch/case. This commit removes the assertions within the switch/case. Thinko in commit 765cbfdc9263. Author: Man Zeng Reviewed-by: Kirill Reshke Discussion: https://postgr.es/m/tencent_40F8C1D82E2EE28065009AAA@qq.com --- src/backend/commands/alter.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/src/backend/commands/alter.c b/src/backend/commands/alter.c index f7b2389b019..08957104c70 100644 --- a/src/backend/commands/alter.c +++ b/src/backend/commands/alter.c @@ -117,27 +117,21 @@ report_namespace_conflict(Oid classId, const char *name, Oid nspOid) switch (classId) { case ConversionRelationId: - Assert(OidIsValid(nspOid)); msgfmt = gettext_noop("conversion \"%s\" already exists in schema \"%s\""); break; case StatisticExtRelationId: - Assert(OidIsValid(nspOid)); msgfmt = gettext_noop("statistics object \"%s\" already exists in schema \"%s\""); break; case TSParserRelationId: - Assert(OidIsValid(nspOid)); msgfmt = gettext_noop("text search parser \"%s\" already exists in schema \"%s\""); break; case TSDictionaryRelationId: - Assert(OidIsValid(nspOid)); msgfmt = gettext_noop("text search dictionary \"%s\" already exists in schema \"%s\""); break; case TSTemplateRelationId: - Assert(OidIsValid(nspOid)); msgfmt = gettext_noop("text search template \"%s\" already exists in schema \"%s\""); break; case TSConfigRelationId: - Assert(OidIsValid(nspOid)); msgfmt = gettext_noop("text search configuration \"%s\" already exists in schema \"%s\""); break; default: