database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-10-21 02:52:47 +03:00
Code Activity

bufmgr: Fix signedness of mask variable in BufferSync()

Browse Source 
BM_PERMANENT is defined as 1U<<31, which is a negative number when interpreted
as a signed integer. Unfortunately the mask variable in BufferSync() was
signed. This has been wrong for a long time, but failed to fail, due to
integer conversion rules.

However, in an upcoming patch the width of the state variable will be
increased, with the wrong signedness leading to never flushing permanent
buffers - luckily caught in a test.

It seems better to fix this separately, instead of doing so as part of a
large, otherwise mechanical, patch.

Reviewed-by: Matthias van de Meent <boekewurm+postgres@gmail.com>
Discussion: https://postgr.es/m/fvfmkr5kk4nyex56ejgxj3uzi63isfxovp2biecb4bspbjrze7@az2pljabhnff
This commit is contained in:
Andres Freund
2025-10-08 14:34:30 -04:00
parent 3c2b97b29e
commit 2a2e1b470b
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/backend/storage/buffer/bufmgr.c
View File

@@ -3321,7 +3321,7 @@ BufferSync(int flags)
Oid last_tsid;
binaryheap *ts_heap;
int i;
int mask = BM_DIRTY;
uint32 mask = BM_DIRTY;
WritebackContext wb_context;
/*