database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-06-16 06:01:02 +03:00
Code Activity

CREATE INDEX: do update index stats if autovacuum=off.

Browse Source 
This fixes a thinko from commit d611f8b15.  The intent was to prevent
updating the stats of the pre-existing heap if autovacuum is off,
but it also disabled updating the stats of the just-created index.
There is AFAICS no good reason to do the latter, since there could not
be any pre-existing stats to refrain from overwriting, and the zeroed
stats that are there to begin with are very unlikely to be useful.
Moreover, the change broke our cross-version upgrade tests again.

Author: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/1116282.1741374848@sss.pgh.pa.us
This commit is contained in:
Tom Lane
2025-03-10 17:49:27 -04:00
parent f7c566a1a2
commit 29d6808ede
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/backend/catalog/index.c
View File

@ -2847,20 +2847,20 @@ index_update_stats(Relation rel,
* statistics, as the table statistics may be restored before the index is * statistics, as the table statistics may be restored before the index is
* created, and we want to preserve the restored table statistics. * created, and we want to preserve the restored table statistics.
*/ */
if (AutoVacuumingActive()) if (rel->rd_rel->relkind == RELKIND_RELATION ||
rel->rd_rel->relkind == RELKIND_TOASTVALUE ||
rel->rd_rel->relkind == RELKIND_MATVIEW)
{ {
if (rel->rd_rel->relkind == RELKIND_RELATION || if (AutoVacuumingActive())
rel->rd_rel->relkind == RELKIND_TOASTVALUE ||
rel->rd_rel->relkind == RELKIND_MATVIEW)
{ {
StdRdOptions *options = (StdRdOptions *) rel->rd_options; StdRdOptions *options = (StdRdOptions *) rel->rd_options;
if (options != NULL && !options->autovacuum.enabled) if (options != NULL && !options->autovacuum.enabled)
update_stats = false; update_stats = false;
} }
else
update_stats = false;
} }
else
update_stats = false;
/* /*
* Finish I/O and visibility map buffer locks before * Finish I/O and visibility map buffer locks before