mirror of
https://github.com/postgres/postgres.git
synced 2025-11-09 06:21:09 +03:00
Collect built-in LWLock tranche names statically, not dynamically.
There is little point in using the LWLockRegisterTranche mechanism for built-in tranche names. It wastes cycles, it creates opportunities for bugs (since failing to register a tranche name is a very hard-to-detect problem), and the lack of any centralized list of names encourages sloppy nonconformity in name choices. Moreover, since we have a centralized list of the tranches anyway in enum BuiltinTrancheIds, we're certainly not buying any flexibility in return for these disadvantages. Hence, nuke all the backend-internal LWLockRegisterTranche calls, and instead provide a const array of the builtin tranche names. (I have in mind to change a bunch of these names shortly, but this patch is just about getting them into one place.) Discussion: https://postgr.es/m/9056.1589419765@sss.pgh.pa.us
This commit is contained in:
@@ -235,9 +235,6 @@ SimpleLruInit(SlruCtl ctl, const char *name, int nslots, int nlsns,
|
||||
else
|
||||
Assert(found);
|
||||
|
||||
/* Register SLRU tranche in the main tranches array */
|
||||
LWLockRegisterTranche(tranche_id, name);
|
||||
|
||||
/*
|
||||
* Initialize the unshared control struct, including directory path. We
|
||||
* assume caller set PagePrecedes.
|
||||
|
||||
Reference in New Issue
Block a user