database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-07 00:36:50 +03:00
Code Activity

Include GUC's unit, if it has one, in out-of-range error messages.

Browse Source 
This should reduce confusion in cases where we've applied a units
conversion, so that the number being reported (and the quoted range
limits) are in some other units than what the user gave in the
setting we're rejecting.

Some of the changes here assume that float GUCs can have units,
which isn't true just yet, but will be shortly.

Discussion: https://postgr.es/m/3811.1552169665@sss.pgh.pa.us
This commit is contained in:
Tom Lane
2019-03-10 13:18:17 -04:00
parent ac75959cdc
commit 28a65fc360
2 changed files with 66 additions and 49 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/test/regress/expected/guc.out
View File

@ -510,7 +510,7 @@ SELECT '2006-08-13 12:34:56'::timestamptz;
SET seq_page_cost TO 'NaN';
ERROR: parameter "seq_page_cost" requires a numeric value
SET vacuum_cost_delay TO '10s';
ERROR: 10000 is outside the valid range for parameter "vacuum_cost_delay" (0 .. 100)
ERROR: 10000 ms is outside the valid range for parameter "vacuum_cost_delay" (0 .. 100)
SET geqo_selection_bias TO '-infinity';
ERROR: -Infinity is outside the valid range for parameter "geqo_selection_bias" (1.5 .. 2)
--