database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-30 11:03:19 +03:00
Code Activity

Bruce and all:

Browse Source 
Here's a patch to fix the " '.' not allowed in db path" problem I ran into.
I removed '.' from the set of illegial characters, but added backtick. I also
included an explicit test for attempting include a reference to a parent dir.

How that?

Ross
This commit is contained in:
Bruce Momjian
2000-03-08 01:46:47 +00:00
parent ab7fd11846
commit 26c953e373
1 changed files with 9 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/backend/utils/misc/database.c
View File

@ -8,7 +8,7 @@
* *
* *
* IDENTIFICATION * IDENTIFICATION
* $Header: /cvsroot/pgsql/src/backend/utils/misc/Attic/database.c,v 1.35 2000/01/26 05:57:28 momjian Exp $ * $Header: /cvsroot/pgsql/src/backend/utils/misc/Attic/database.c,v 1.36 2000/03/08 01:46:47 momjian Exp $
* *
*------------------------------------------------------------------------- *-------------------------------------------------------------------------
*/ */
@ -83,22 +83,27 @@ ExpandDatabasePath(const char *dbpath)
DataDir, SEP_CHAR, SEP_CHAR, dbpath); DataDir, SEP_CHAR, SEP_CHAR, dbpath);
} }
/* check for illegal characters in dbpath */ /* check for illegal characters in dbpath
* these should really throw an error, shouldn't they? or else all callers
* need to test for NULL */
for(cp = buf; *cp; cp++) for(cp = buf; *cp; cp++)
{ {
/* The following characters will not be allowed anywhere in the database /* The following characters will not be allowed anywhere in the database
path. (Do not include the slash here.) */ path. (Do not include the slash or '.' here.) */
char illegal_dbpath_chars[] = char illegal_dbpath_chars[] =
"\001\002\003\004\005\006\007\010" "\001\002\003\004\005\006\007\010"
"\011\012\013\014\015\016\017\020" "\011\012\013\014\015\016\017\020"
"\021\022\023\024\025\026\027\030" "\021\022\023\024\025\026\027\030"
"\031\032\033\034\035\036\037" "\031\032\033\034\035\036\037"
"'."; "'`";
const char *cx; const char *cx;
for (cx = illegal_dbpath_chars; *cx; cx++) for (cx = illegal_dbpath_chars; *cx; cx++)
if (*cp == *cx) if (*cp == *cx)
return NULL; return NULL;
/* don't allow access to parent dirs */
if (strncmp(cp, "/../", 4) == 0 )
return NULL ;
} }
return pstrdup(buf); return pstrdup(buf);