database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-06-14 18:42:34 +03:00
Code Activity

Fix busted Assert for CREATE MATVIEW ... WITH NO DATA.

Browse Source 
Commit 874fe3aea changed the command tag returned for CREATE MATVIEW/CREATE
TABLE AS ... WITH NO DATA, but missed that there was code in spi.c that
expected the command tag to always be "SELECT".  Fortunately, the
consequence was only an Assert failure, so this oversight should have no
impact in production builds.

Since this code path was evidently un-exercised, add a regression test.

Per report from Shivam Saxena. Back-patch to 9.3, like the previous commit.

Michael Paquier

Report: <97218716-480B-4527-B5CD-D08D798A0C7B@dresources.com>
This commit is contained in:
Tom Lane
2016-08-11 11:22:25 -04:00
parent 042b6beeeb
commit 268d92e533
3 changed files with 51 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/backend/executor/spi.c
View File

@ -2186,15 +2186,23 @@ _SPI_execute_plan(SPIPlanPtr plan, ParamListInfo paramLI,
*/ */
if (IsA(stmt, CreateTableAsStmt)) if (IsA(stmt, CreateTableAsStmt))
{ {
Assert(strncmp(completionTag, "SELECT ", 7) == 0); CreateTableAsStmt *ctastmt = (CreateTableAsStmt *) stmt;
_SPI_current->processed = strtoul(completionTag + 7,
NULL, 10); if (strncmp(completionTag, "SELECT ", 7) == 0)
_SPI_current->processed =
strtoul(completionTag + 7, NULL, 10);
else
{
/* Must be a CREATE ... WITH NO DATA */
Assert(ctastmt->into->skipData);
_SPI_current->processed = 0;
}
/* /*
* For historical reasons, if CREATE TABLE AS was spelled * For historical reasons, if CREATE TABLE AS was spelled
* as SELECT INTO, return a special return code. * as SELECT INTO, return a special return code.
*/ */
if (((CreateTableAsStmt *) stmt)->is_select_into) if (ctastmt->is_select_into)
res = SPI_OK_SELINTO; res = SPI_OK_SELINTO;
} }
else if (IsA(stmt, CopyStmt)) else if (IsA(stmt, CopyStmt))

25
src/test/regress/expected/matview.out
View File

@ -553,3 +553,28 @@ REFRESH MATERIALIZED VIEW mv_foo;
REFRESH MATERIALIZED VIEW CONCURRENTLY mv_foo; REFRESH MATERIALIZED VIEW CONCURRENTLY mv_foo;
DROP OWNED BY user_dw CASCADE; DROP OWNED BY user_dw CASCADE;
DROP ROLE user_dw; DROP ROLE user_dw;
-- make sure that create WITH NO DATA works via SPI
BEGIN;
CREATE FUNCTION mvtest_func()
RETURNS void AS $$
BEGIN
CREATE MATERIALIZED VIEW mvtest1 AS SELECT 1 AS x;
CREATE MATERIALIZED VIEW mvtest2 AS SELECT 1 AS x WITH NO DATA;
END;
$$ LANGUAGE plpgsql;
SELECT mvtest_func();
mvtest_func
-------------
(1 row)
SELECT * FROM mvtest1;
x
---
1
(1 row)
SELECT * FROM mvtest2;
ERROR: materialized view "mvtest2" has not been populated
HINT: Use the REFRESH MATERIALIZED VIEW command.
ROLLBACK;

14
src/test/regress/sql/matview.sql
View File

@ -224,3 +224,17 @@ REFRESH MATERIALIZED VIEW mv_foo;
REFRESH MATERIALIZED VIEW CONCURRENTLY mv_foo; REFRESH MATERIALIZED VIEW CONCURRENTLY mv_foo;
DROP OWNED BY user_dw CASCADE; DROP OWNED BY user_dw CASCADE;
DROP ROLE user_dw; DROP ROLE user_dw;
-- make sure that create WITH NO DATA works via SPI
BEGIN;
CREATE FUNCTION mvtest_func()
RETURNS void AS $$
BEGIN
CREATE MATERIALIZED VIEW mvtest1 AS SELECT 1 AS x;
CREATE MATERIALIZED VIEW mvtest2 AS SELECT 1 AS x WITH NO DATA;
END;
$$ LANGUAGE plpgsql;
SELECT mvtest_func();
SELECT * FROM mvtest1;
SELECT * FROM mvtest2;
ROLLBACK;