database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-06-14 18:42:34 +03:00
Code Activity

Repair "Halloween problem" in EvalPlanQual: a tuple that's been inserted by

Browse Source 
our own command (or more generally, xmin = our xact and cmin >= current
command ID) should not be seen as good.  Else we may try to update rows
we already updated.  This error was inserted last August while fixing the
even bigger problem that the old coding wouldn't see *any* tuples inserted
by our own transaction as good.  Per report from Euler Taveira de Oliveira.
This commit is contained in:
Tom Lane
2006-01-12 21:48:53 +00:00
parent db0558c113
commit 25b9b1b042
3 changed files with 32 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/backend/commands/trigger.c
View File

@ -7,7 +7,7 @@
* Portions Copyright (c) 1994, Regents of the University of California
*
* IDENTIFICATION
* $PostgreSQL: pgsql/src/backend/commands/trigger.c,v 1.198 2006/01/05 10:07:45 petere Exp $
* $PostgreSQL: pgsql/src/backend/commands/trigger.c,v 1.199 2006/01/12 21:48:52 tgl Exp $
*
*-------------------------------------------------------------------------
*/
@ -1736,7 +1736,8 @@ ltrmark:;
epqslot = EvalPlanQual(estate,
relinfo->ri_RangeTableIndex,
&update_ctid,
update_xmax);
update_xmax,
cid);
if (!TupIsNull(epqslot))
{
*tid = update_ctid;