database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-15 19:21:59 +03:00
Code Activity

Remove pstrdup of TextDatumGetCString

Browse Source 
The result of TextDatumGetCString is already palloc'ed.
This commit is contained in:
Peter Eisentraut
2017-04-14 12:54:09 -04:00
parent 0c22327f26
commit 25371a72b9
3 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/backend/catalog/pg_subscription.c
View File

@ -75,7 +75,7 @@ GetSubscription(Oid subid, bool missing_ok)
Anum_pg_subscription_subconninfo, Anum_pg_subscription_subconninfo,
&isnull); &isnull);
Assert(!isnull); Assert(!isnull);
sub->conninfo = pstrdup(TextDatumGetCString(datum)); sub->conninfo = TextDatumGetCString(datum);
/* Get slotname */ /* Get slotname */
datum = SysCacheGetAttr(SUBSCRIPTIONOID, datum = SysCacheGetAttr(SUBSCRIPTIONOID,
@ -207,7 +207,7 @@ textarray_to_stringlist(ArrayType *textarray)
return NIL; return NIL;
for (i = 0; i < nelems; i++) for (i = 0; i < nelems; i++)
res = lappend(res, makeString(pstrdup(TextDatumGetCString(elems[i])))); res = lappend(res, makeString(TextDatumGetCString(elems[i])));
return res; return res;
} }

2
src/backend/commands/subscriptioncmds.c
View File

@ -767,7 +767,7 @@ DropSubscription(DropSubscriptionStmt *stmt, bool isTopLevel)
datum = SysCacheGetAttr(SUBSCRIPTIONOID, tup, datum = SysCacheGetAttr(SUBSCRIPTIONOID, tup,
Anum_pg_subscription_subconninfo, &isnull); Anum_pg_subscription_subconninfo, &isnull);
Assert(!isnull); Assert(!isnull);
conninfo = pstrdup(TextDatumGetCString(datum)); conninfo = TextDatumGetCString(datum);
/* Get slotname */ /* Get slotname */
datum = SysCacheGetAttr(SUBSCRIPTIONOID, tup, datum = SysCacheGetAttr(SUBSCRIPTIONOID, tup,

2
src/backend/replication/logical/tablesync.c
View File

@ -612,7 +612,7 @@ fetch_remote_table_info(char *nspname, char *relname,
while (tuplestore_gettupleslot(res->tuplestore, true, false, slot)) while (tuplestore_gettupleslot(res->tuplestore, true, false, slot))
{ {
lrel->attnames[natt] = lrel->attnames[natt] =
pstrdup(TextDatumGetCString(slot_getattr(slot, 1, &isnull))); TextDatumGetCString(slot_getattr(slot, 1, &isnull));
Assert(!isnull); Assert(!isnull);
lrel->atttyps[natt] = DatumGetObjectId(slot_getattr(slot, 2, &isnull)); lrel->atttyps[natt] = DatumGetObjectId(slot_getattr(slot, 2, &isnull));
Assert(!isnull); Assert(!isnull);