database/postgres
database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-04-25 21:42:33 +03:00
Code

Manual cleanup and pgindent of pgstat and bufmgr related code

Browse Source 
This is in preparation for commiting a larger patch series in the area.

Discussion: https://postgr.es/m/CAAKRu_bHwGEbzNxxy+MQDkrsgog6aO6iUvajJ4d6PD98gFU7+w@mail.gmail.com
This commit is contained in:
Andres Freund 2023-01-13 15:23:09 -08:00
parent d46a9792a8
commit 250c8ee07e
7 changed files with 19 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
src/backend/storage/buffer/bufmgr.c
View File

@ -3297,8 +3297,8 @@ DropRelationsAllBuffers(SMgrRelation *smgr_reln, int nlocators)
uint32 buf_state;
/*
* As in DropRelationBuffers, an unlocked precheck should be
* safe and saves some cycles.
* As in DropRelationBuffers, an unlocked precheck should be safe and
* saves some cycles.
*/
if (!use_bsearch)
@ -3425,8 +3425,8 @@ DropDatabaseBuffers(Oid dbid)
uint32 buf_state;
/*
* As in DropRelationBuffers, an unlocked precheck should be
* safe and saves some cycles.
* As in DropRelationBuffers, an unlocked precheck should be safe and
* saves some cycles.
*/
if (bufHdr->tag.dbOid != dbid)
continue;
@ -3572,8 +3572,8 @@ FlushRelationBuffers(Relation rel)
bufHdr = GetBufferDescriptor(i);
/*
* As in DropRelationBuffers, an unlocked precheck should be
* safe and saves some cycles.
* As in DropRelationBuffers, an unlocked precheck should be safe and
* saves some cycles.
*/
if (!BufTagMatchesRelFileLocator(&bufHdr->tag, &rel->rd_locator))
continue;
@ -3645,8 +3645,8 @@ FlushRelationsAllBuffers(SMgrRelation *smgrs, int nrels)
uint32 buf_state;
/*
* As in DropRelationBuffers, an unlocked precheck should be
* safe and saves some cycles.
* As in DropRelationBuffers, an unlocked precheck should be safe and
* saves some cycles.
*/
if (!use_bsearch)
@ -3880,8 +3880,8 @@ FlushDatabaseBuffers(Oid dbid)
bufHdr = GetBufferDescriptor(i);
/*
* As in DropRelationBuffers, an unlocked precheck should be
* safe and saves some cycles.
* As in DropRelationBuffers, an unlocked precheck should be safe and
* saves some cycles.
*/
if (bufHdr->tag.dbOid != dbid)
continue;

4
src/backend/storage/buffer/localbuf.c
View File

@ -610,8 +610,8 @@ AtProcExit_LocalBuffers(void)
{
/*
* We shouldn't be holding any remaining pins; if we are, and assertions
* aren't enabled, we'll fail later in DropRelationBuffers while
* trying to drop the temp rels.
* aren't enabled, we'll fail later in DropRelationBuffers while trying to
* drop the temp rels.
*/
CheckForLocalBufferLeaks();
}

1
src/backend/utils/activity/pgstat.c
View File

@ -986,6 +986,7 @@ pgstat_build_snapshot(void)
entry->data = MemoryContextAlloc(pgStatLocal.snapshot.context,
kind_info->shared_size);
/*
* Acquire the LWLock directly instead of using
* pg_stat_lock_entry_shared() which requires a reference.

1
src/backend/utils/activity/pgstat_relation.c
View File

@ -783,6 +783,7 @@ pgstat_relation_flush_cb(PgStat_EntryRef *entry_ref, bool nowait)
if (lstats->t_counts.t_numscans)
{
TimestampTz t = GetCurrentTransactionStopTimestamp();
if (t > tabentry->lastscan)
tabentry->lastscan = t;
}

1
src/include/pgstat.h
View File

@ -476,6 +476,7 @@ extern void pgstat_report_connect(Oid dboid);
extern PgStat_StatDBEntry *pgstat_fetch_stat_dbentry(Oid dboid);
/*
* Functions in pgstat_function.c
*/

1
src/include/utils/pgstat_internal.h
View File

@ -626,6 +626,7 @@ extern void pgstat_wal_snapshot_cb(void);
extern bool pgstat_subscription_flush_cb(PgStat_EntryRef *entry_ref, bool nowait);
extern void pgstat_subscription_reset_timestamp_cb(PgStatShared_Common *header, TimestampTz ts);
/*
* Functions in pgstat_xact.c
*/