database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-06-17 17:02:08 +03:00
Code Activity

Mark pg_stat_reset_shared as strict

Browse Source 
This is the proper fix for bug #6082 about
pg_stat_reset_shared(NULL) causing a crash, and it reverts
commit 79aa44536f on head.

The workaround of throwing an error from inside the function is
left on backbranches (including 9.1) since this change requires
a new initdb.
This commit is contained in:
Magnus Hagander
2011-07-03 13:15:58 +02:00
parent 426cafc46c
commit 24e2d4b6ba
3 changed files with 4 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/backend/utils/adt/pgstatfuncs.c
View File

@ -1537,17 +1537,9 @@ pg_stat_reset(PG_FUNCTION_ARGS)
Datum
pg_stat_reset_shared(PG_FUNCTION_ARGS)
{
if (PG_ARGISNULL(0))
/*
* Same error message as in pgstat_reset_shared_counters(),
* to keep translations the same.
*/
ereport(ERROR,
(errcode(ERRCODE_INVALID_PARAMETER_VALUE),
errmsg("unrecognized reset target: \"%s\"", "null"),
errhint("Target must be \"bgwriter\".")));
char *target = text_to_cstring(PG_GETARG_TEXT_PP(0));
pgstat_reset_shared_counters(text_to_cstring(PG_GETARG_TEXT_PP(0)));
pgstat_reset_shared_counters(target);
PG_RETURN_VOID();
}