From 24cb3a08a43b5a48f5fba4a83d297218e2e748c5 Mon Sep 17 00:00:00 2001 From: Fujii Masao Date: Fri, 9 Jan 2026 20:24:00 +0900 Subject: [PATCH] Use IsA() macro in define.c, for sake of consistency. Commit 63d1b1cf7f1 replaced a direct nodeTag() comparison with the IsA() macro in copy.c, but a similar direct comparison remained in define.c. This commit replaces that comparison with IsA() for consistency. Author: Fujii Masao Reviewed-by: Chao Li Reviewed-by: Shinya Kato Reviewed-by: Bertrand Drouvot Discussion: https://postgr.es/m/CAHGQGwGjWGS89_sTx=sbPm0FQemyQQrfTKm=taUhAJFV5k-9cw@mail.gmail.com --- src/backend/commands/define.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/commands/define.c b/src/backend/commands/define.c index 63601a2c0b4..8313431397f 100644 --- a/src/backend/commands/define.c +++ b/src/backend/commands/define.c @@ -349,7 +349,7 @@ defGetStringList(DefElem *def) (errcode(ERRCODE_SYNTAX_ERROR), errmsg("%s requires a parameter", def->defname))); - if (nodeTag(def->arg) != T_List) + if (!IsA(def->arg, List)) elog(ERROR, "unrecognized node type: %d", (int) nodeTag(def->arg)); foreach(cell, (List *) def->arg)