database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-31 22:04:40 +03:00
Code Activity

Simplify matching pattern check in TAP tests of pg_receivewal

Browse Source 
A check in the ZLIB portion of the test to match the name of a
non-compressed partial segment with a completed compressed segment was
using m//, while a simple equality check is enough.  This makes the test
a bit stricter without impacting its coverage.

Author: Kyotaro Horiguchi
Discussion: https://postgr.es/m/20210726.174622.826565852378770261.horikyota.ntt@gmail.com
This commit is contained in:
Michael Paquier
2021-07-27 10:58:21 +09:00
parent f7a9a3d4b2
commit 24ba1a87e4
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/bin/pg_basebackup/t/020_pg_receivewal.pl
View File

@ -111,7 +111,7 @@ SKIP:
# of the previous partial, now-completed WAL segment is updated, keeping # of the previous partial, now-completed WAL segment is updated, keeping
# its base number. # its base number.
$partial_wals[0] =~ s/\.partial$/.gz/; $partial_wals[0] =~ s/\.partial$/.gz/;
is($zlib_wals[0] =~ m/$partial_wals[0]/, is($zlib_wals[0] eq $partial_wals[0],
1, "one partial WAL segment is now completed"); 1, "one partial WAL segment is now completed");
# Update the list of partial wals with the current one. # Update the list of partial wals with the current one.
@partial_wals = @zlib_partial_wals; @partial_wals = @zlib_partial_wals;