mirror of
https://github.com/postgres/postgres.git
synced 2025-09-03 15:22:11 +03:00
For inplace update, send nontransactional invalidations.
The inplace update survives ROLLBACK. The inval didn't, so another backend's DDL could then update the row without incorporating the inplace update. In the test this fixes, a mix of CREATE INDEX and ALTER TABLE resulted in a table with an index, yet relhasindex=f. That is a source of index corruption. Back-patch to v12 (all supported versions). The back branch versions don't change WAL, because those branches just added end-of-recovery SIResetAll(). All branches change the ABI of extern function PrepareToInvalidateCacheTuple(). No PGXN extension calls that, and there's no apparent use case in extensions. Reviewed by Nitin Motiani and (in earlier versions) Andres Freund. Discussion: https://postgr.es/m/20240523000548.58.nmisch@google.com
This commit is contained in:
@@ -975,11 +975,6 @@ EventTriggerOnLogin(void)
|
||||
* this instead of regular updates serves two purposes. First,
|
||||
* that avoids possible waiting on the row-level lock. Second,
|
||||
* that avoids dealing with TOAST.
|
||||
*
|
||||
* Changes made by inplace update may be lost due to
|
||||
* concurrent normal updates; see inplace-inval.spec. However,
|
||||
* we are OK with that. The subsequent connections will still
|
||||
* have a chance to set "dathasloginevt" to false.
|
||||
*/
|
||||
systable_inplace_update_finish(state, tuple);
|
||||
}
|
||||
|
Reference in New Issue
Block a user