database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-09-02 04:21:28 +03:00
Code Activity

Fix code comments regarding logical decoding

Browse Source 
Back in 3b02ea4f07 I added some comments in various places to explain
how logical decoding and other things worked.  Not all of the changes
were welcome, because they were misleading or wrong.  This changes them
a little bit to make them more accurate.

Some other comments are also changed to be more accurate.  Also, fix a
bunch of typos.

Author: Álvaro Herrera, Craig Ringer

Andres Freund reviewed some parts of this.
This commit is contained in:
Alvaro Herrera
2016-05-02 16:04:29 -03:00
parent 21c2b1c611
commit 234a266066
3 changed files with 27 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/include/replication/slot.h
View File

@@ -66,7 +66,12 @@ typedef struct ReplicationSlotPersistentData
/* oldest LSN that might be required by this replication slot */
XLogRecPtr restart_lsn;
/* oldest LSN that the client has acked receipt for */
/*
* Oldest LSN that the client has acked receipt for. This is used as the
* start_lsn point in case the client doesn't specify one, and also as a
* safety measure to back off in case the client specifies a start_lsn
* that's further in the future than this value.
*/
XLogRecPtr confirmed_flush;
/* plugin name */
@@ -113,11 +118,10 @@ typedef struct ReplicationSlot
/* all the remaining data is only used for logical slots */
/* ----
/*
* When the client has confirmed flushes >= candidate_xmin_lsn we can
* advance the catalog xmin, when restart_valid has been passed,
* advance the catalog xmin. When restart_valid has been passed,
* restart_lsn can be increased.
* ----
*/
TransactionId candidate_catalog_xmin;
XLogRecPtr candidate_xmin_lsn;