database/postgres
database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-05-06 19:59:18 +03:00
Code

Don't allow to set replication slot_name as ''.

Browse Source 
We don't allow to create replication slot_name as an empty string ('') via
SQL API pg_create_logical_replication_slot() but it is allowed to be set
via Alter Subscription command. This will lead to apply worker repeatedly
keep trying to stream data via slot_name '' and the user is not allowed to
create the slot with that name.

Author: Japin Li
Reviewed-By: Ranier Vilela, Amit Kapila
Backpatch-through: 10, where it was introduced
Discussion: https://postgr.es/m/MEYP282MB1669CBD98E721C77CA696499B61A9@MEYP282MB1669.AUSP282.PROD.OUTLOOK.COM
This commit is contained in:
Amit Kapila 2021-07-19 11:32:08 +05:30
parent e8321a3190
commit 22fd784afd
3 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/backend/commands/subscriptioncmds.c
View File

@ -39,6 +39,7 @@
#include "replication/logicallauncher.h" #include "replication/logicallauncher.h"
#include "replication/origin.h" #include "replication/origin.h"
#include "replication/slot.h"
#include "replication/walreceiver.h" #include "replication/walreceiver.h"
#include "replication/walsender.h" #include "replication/walsender.h"
#include "replication/worker_internal.h" #include "replication/worker_internal.h"
@ -145,6 +146,8 @@ parse_subscription_options(List *options, bool *connect, bool *enabled_given,
/* Setting slot_name = NONE is treated as no slot name. */ /* Setting slot_name = NONE is treated as no slot name. */
if (strcmp(*slot_name, "none") == 0) if (strcmp(*slot_name, "none") == 0)
*slot_name = NULL; *slot_name = NULL;
else
ReplicationSlotValidateName(*slot_name, ERROR);
} }
else if (strcmp(defel->defname, "copy_data") == 0 && copy_data) else if (strcmp(defel->defname, "copy_data") == 0 && copy_data)
{ {

3
src/test/regress/expected/subscription.out
View File

@ -86,6 +86,9 @@ ALTER SUBSCRIPTION testsub SET PUBLICATION testpub2, testpub3 WITH (refresh = fa
ALTER SUBSCRIPTION testsub CONNECTION 'dbname=doesnotexist2'; ALTER SUBSCRIPTION testsub CONNECTION 'dbname=doesnotexist2';
ALTER SUBSCRIPTION testsub SET (slot_name = 'newname'); ALTER SUBSCRIPTION testsub SET (slot_name = 'newname');
-- fail -- fail
ALTER SUBSCRIPTION testsub SET (slot_name = '');
ERROR: replication slot name "" is too short
-- fail
ALTER SUBSCRIPTION doesnotexist CONNECTION 'dbname=doesnotexist2'; ALTER SUBSCRIPTION doesnotexist CONNECTION 'dbname=doesnotexist2';
ERROR: subscription "doesnotexist" does not exist ERROR: subscription "doesnotexist" does not exist
ALTER SUBSCRIPTION testsub SET (create_slot = false); ALTER SUBSCRIPTION testsub SET (create_slot = false);

3
src/test/regress/sql/subscription.sql
View File

@ -65,6 +65,9 @@ ALTER SUBSCRIPTION testsub SET PUBLICATION testpub2, testpub3 WITH (refresh = fa
ALTER SUBSCRIPTION testsub CONNECTION 'dbname=doesnotexist2'; ALTER SUBSCRIPTION testsub CONNECTION 'dbname=doesnotexist2';
ALTER SUBSCRIPTION testsub SET (slot_name = 'newname'); ALTER SUBSCRIPTION testsub SET (slot_name = 'newname');
-- fail
ALTER SUBSCRIPTION testsub SET (slot_name = '');
-- fail -- fail
ALTER SUBSCRIPTION doesnotexist CONNECTION 'dbname=doesnotexist2'; ALTER SUBSCRIPTION doesnotexist CONNECTION 'dbname=doesnotexist2';
ALTER SUBSCRIPTION testsub SET (create_slot = false); ALTER SUBSCRIPTION testsub SET (create_slot = false);