database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2026-10-23 13:29:09 +03:00
Code Activity

pg_rewind: Check the data checksum states of source and target

Browse Source 
pg_rewind installs the source's control file on the target, but every
block it does not copy keeps the target's content.  With checksums
enabled on the target and disabled on the source, the rewound server
claims enabled checksums while the blocks copied from the source have
none, and fails checksum verification as soon as it reads them; in the
worst case every connection attempt dies on an unverifiable catalog
page.

Comparing the control files is not enough.  Replay on the rewound
server resumes from the last common checkpoint and adopts the data
checksum state recorded there, so an offline disable on the source
after the divergence leaves both control files saying "off" while the
rewound server still resumes with verification enabled.  Check the
state carried by the divergence checkpoint as well, which pg_rewind
already reads.

Refuse both cases, and an interrupted online transition on either
side, same as pg_checksums does.  The opposite mismatch, checksums on
the source only, is allowed with a warning: recovery under the backup
label adopts the divergence state, so the rewound server keeps
checksums disabled (or converges through the replayed WAL if the
source enabled them online), and no page can fail verification.

Author: Zsolt Parragi <zsolt.parragi@percona.com>
Reviewed-by: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Reviewed-by: Daniel Gustafsson <daniel@yesql.se>
Discussion: https://postgr.es/m/anwm6UPxoVS41QA2@bdtpg
Backpatch-through: 19
This commit is contained in:
Daniel Gustafsson
2026-09-14 15:33:01 +02:00
parent 3e70c527cc
commit 227f8ea19a
7 changed files with 410 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
doc/src/sgml/ref/pg_rewind.sgml
View File

@@ -124,6 +124,20 @@ PostgreSQL documentation
<literal>on</literal>, but is enabled by default.
</para>
<para>
The data checksum states of the source and target server must be
compatible. <application>pg_rewind</application> refuses to run if an
online checksum state transition was interrupted on either server, or
if data checksums are enabled on the target server, or were enabled at
the point of divergence, while the source server runs without them: the
rewound server would fail checksum verification on the blocks copied
from the source. The opposite combination is allowed with a warning;
the rewound server keeps data checksums disabled unless the source
server enabled them online after the point of divergence. See
<xref linkend="app-pgchecksums"/> for how to change the state
consistently across a replication setup.
</para>
<warning>
<title>Warning: Failures While Rewinding</title>
<para>