database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-18 17:42:25 +03:00
Code Activity

Remove some long-obsolete code that was causing a strange error message

Browse Source 
when someone attempts to create a column of a composite datatype.  For
now, just make sure we produce a reasonable error at the 'right place'.
Not sure if this will be made to work before 7.5, but make it act
reasonably in case nothing more gets done.
This commit is contained in:
Tom Lane
2004-06-04 03:24:04 +00:00
parent 7eb2ff799e
commit 223b813d0e
2 changed files with 10 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
src/backend/parser/analyze.c
View File

@ -6,7 +6,7 @@
* Portions Copyright (c) 1996-2003, PostgreSQL Global Development Group
* Portions Copyright (c) 1994, Regents of the University of California
*
* $PostgreSQL: pgsql/src/backend/parser/analyze.c,v 1.302 2004/05/30 23:40:32 neilc Exp $
* $PostgreSQL: pgsql/src/backend/parser/analyze.c,v 1.303 2004/06/04 03:24:04 tgl Exp $
*
*-------------------------------------------------------------------------
*/
@ -3049,23 +3049,10 @@ makeFromExpr(List *fromlist, Node *quals)
static void
transformColumnType(ParseState *pstate, ColumnDef *column)
{
TypeName *typename = column->typename;
Type ctype = typenameType(typename);
/*
* Is this the name of a complex type? If so, implement it as a set.
*
* XXX this is a hangover from ancient Berkeley code that probably
* doesn't work anymore anyway.
* All we really need to do here is verify that the type is valid.
*/
if (typeTypeRelid(ctype) != InvalidOid)
{
/*
* (Eventually add in here that the set can only contain one
* element.)
*/
typename->setof = true;
}
Type ctype = typenameType(column->typename);
ReleaseSysCache(ctype);
}