database/postgres
database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-04-21 12:05:57 +03:00
Code

Fix ancient bug in ecpg's pthread_once() emulation for Windows.

Browse Source 
We must not set the "done" flag until after we've executed the
initialization function.  Otherwise, other threads can fall through
the initial unlocked test before initialization is really complete.

This has been seen to cause rare failures of ecpg's thread/descriptor
test, and it could presumably cause other sorts of misbehavior in
threaded ECPG-using applications, since ecpglib relies on
pthread_once() in several places.

Diagnosis and patch by me, based on investigation by Alexander Lakhin.
Back-patch to all supported branches (the bug dates to 2007).

Discussion: https://postgr.es/m/16685-d6cd241872c101d3@postgresql.org
This commit is contained in:
Tom Lane 2020-10-24 13:12:08 -04:00
parent 2771fcee18
commit 21d36747d4
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/interfaces/ecpg/ecpglib/misc.c
View File

@ -477,8 +477,8 @@ win32_pthread_once(volatile pthread_once_t *once, void (*fn) (void))
pthread_mutex_lock(&win32_pthread_once_lock); pthread_mutex_lock(&win32_pthread_once_lock);
if (!*once) if (!*once)
{ {
*once = true;
fn(); fn();
*once = true;
} }
pthread_mutex_unlock(&win32_pthread_once_lock); pthread_mutex_unlock(&win32_pthread_once_lock);
} }