1
0
mirror of https://github.com/postgres/postgres.git synced 2025-11-10 17:42:29 +03:00

Fix some more bugs in signal handlers and process shutdown logic.

WalSndKill was doing things exactly backwards: it should first clear
MyWalSnd (to stop signal handlers from touching MyWalSnd->latch),
then disown the latch, and only then mark the WalSnd struct unused by
clearing its pid field.

Also, WalRcvSigUsr1Handler and worker_spi_sighup failed to preserve
errno, which is surely a requirement for any signal handler.

Per discussion of recent buildfarm failures.  Back-patch as far
as the relevant code exists.
This commit is contained in:
Tom Lane
2014-02-01 16:20:56 -05:00
parent 7e1531a450
commit 214c7a4f0b
3 changed files with 22 additions and 7 deletions

View File

@@ -740,7 +740,11 @@ WalRcvSigHupHandler(SIGNAL_ARGS)
static void
WalRcvSigUsr1Handler(SIGNAL_ARGS)
{
int save_errno = errno;
latch_sigusr1_handler();
errno = save_errno;
}
/* SIGTERM: set flag for main loop, or shutdown immediately if safe */