database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-06-27 23:21:58 +03:00
Code Activity

Emit a warning when an empty string is input to the oid, float4, and

Browse Source 
float8 types. This begins the deprecation of this feature: in 7.6,
this input will be rejected.

Also added a new error code for warnings about deprecated features,
and updated the regression tests.
This commit is contained in:
Neil Conway
2004-03-04 21:47:18 +00:00
parent 0b1f7cccd7
commit 2146bfc869
6 changed files with 54 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
src/backend/utils/adt/float.c
View File

@ -8,7 +8,7 @@
*
*
* IDENTIFICATION
* $PostgreSQL: pgsql/src/backend/utils/adt/float.c,v 1.96 2003/11/29 19:51:58 pgsql Exp $
* $PostgreSQL: pgsql/src/backend/utils/adt/float.c,v 1.97 2004/03/04 21:47:18 neilc Exp $
*
*-------------------------------------------------------------------------
*/
@ -208,6 +208,19 @@ float4in(PG_FUNCTION_ARGS)
errmsg("\"%s\" is out of range for type real", num)));
}
/*
* In releases prior to 7.5, we accepted an empty string as valid
* input (yielding a float4 of 0). In 7.5, we accept empty
* strings, but emit a warning noting that the feature is
* deprecated. In 7.6+, the warning should be replaced by an error.
*/
if (num == endptr)
ereport(WARNING,
(errcode(ERRCODE_WARNING_DEPRECATED_FEATURE),
errmsg("deprecated input syntax for type real: \"\""),
errdetail("This input will be rejected in "
"a future release of PostgreSQL.")));
/*
* if we get here, we have a legal double, still need to check to see
* if it's a legal float
@ -309,6 +322,19 @@ float8in(PG_FUNCTION_ARGS)
errmsg("\"%s\" is out of range for type double precision", num)));
}
/*
* In releases prior to 7.5, we accepted an empty string as valid
* input (yielding a float8 of 0). In 7.5, we accept empty
* strings, but emit a warning noting that the feature is
* deprecated. In 7.6+, the warning should be replaced by an error.
*/
if (num == endptr)
ereport(WARNING,
(errcode(ERRCODE_WARNING_DEPRECATED_FEATURE),
errmsg("deprecated input syntax for type double precision: \"\""),
errdetail("This input will be rejected in "
"a future release of PostgreSQL.")));
CheckFloat8Val(val);
PG_RETURN_FLOAT8(val);