database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-28 23:42:10 +03:00
Code Activity

I made it so it rolled over files at 1MB. My table ended up with 120

Browse Source 
segments, and my indexes had 3(Yes, it DOES work!).
DROP TABLE removed ALL segments from the table, but only the main index
segment.

So it looks like removing the table itself is using mdunlink in md.c,
while removing indexes uses FileNameUnlink() which only unlinks 1 file.
As far as I can tell, calling FileNameUnlink() and mdunlink() is basically
the same, except mdunlink() deletes any extra segments.

I've done some testing and it seems to work.  It also passes regression
tests(except float8, geometry and rules, but that's normal).

If this patch is right, this fixes all known multi-segment problems on
Linux.

Ole Gjerde
This commit is contained in:
Bruce Momjian
1999-05-15 22:31:07 +00:00
parent de81fbd047
commit 2132e062e1
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/backend/catalog/index.c
View File

@ -7,7 +7,7 @@
*
*
* IDENTIFICATION
* $Header: /cvsroot/pgsql/src/backend/catalog/index.c,v 1.71 1999/05/10 00:44:55 momjian Exp $
* $Header: /cvsroot/pgsql/src/backend/catalog/index.c,v 1.72 1999/05/15 22:31:07 momjian Exp $
*
*
* INTERFACE ROUTINES
@ -1187,7 +1187,7 @@ index_destroy(Oid indexId)
*/
ReleaseRelationBuffers(userindexRelation);
if (FileNameUnlink(relpath(userindexRelation->rd_rel->relname.data)) < 0)
if (mdunlink(userindexRelation) != SM_SUCCESS)
elog(ERROR, "amdestroyr: unlink: %m");
index_close(userindexRelation);