database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-30 11:03:19 +03:00
Code Activity

Delete contrib/xml2's legacy implementation of xml_is_well_formed().

Browse Source 
This function is unreferenced in modern usage; it was superseded in 9.1
by a core function of the same name.  It has been left in place in the C
code only so that pre-9.1 SQL definitions of the contrib/xml2 functions
would continue to work.  Six years seems like enough time for people to
have updated to the extension-style version of the xml2 module, so let's
drop this.

The key reason for not keeping it any longer is that we want to stick
an explicit PGDLLEXPORT into PG_FUNCTION_INFO_V1(), and the similarity
of name to the core function creates a conflict that compilers will
complain about.

Extracted from a larger patch for that purpose.  I'm committing this
change separately to give it more visibility in the commit logs.

While at it, remove the documentation entry that claimed that
xml_is_well_formed() is a function provided by contrib/xml2, and
instead mention the even more ancient alias xml_valid().

Laurenz Albe, doc change by me

Patch: <A737B7A37273E048B164557ADEF4A58B53962ED8@ntex2010a.host.magwien.gv.at>
This commit is contained in:
Tom Lane
2016-11-04 18:29:53 -04:00
parent d5f6f13f8e
commit 20540710e8
2 changed files with 5 additions and 50 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
doc/src/sgml/xml2.sgml
View File

@ -53,7 +53,7 @@
<row>
<entry>
<function>
xml_is_well_formed(document)
xml_valid(document)
</function>
</entry>
<entry>
@ -62,10 +62,10 @@
<entry>
<para>
This parses the document text in its parameter and returns true if the
document is well-formed XML. (Note: before PostgreSQL 8.2, this
function was called <function>xml_valid()</>. That is the wrong name
since validity and well-formedness have different meanings in XML.
The old name is still available, but is deprecated.)
document is well-formed XML. (Note: this is an alias for the standard
PostgreSQL function <function>xml_is_well_formed()</>. The
name <function>xml_valid()</> is technically incorrect since validity
and well-formedness have different meanings in XML.)
</para>
</entry>
</row>