database/postgres
database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-05-15 19:15:29 +03:00
Code

Fix corruption of 2PC recovery with subxacts

Browse Source 
Reading 2PC state files during recovery was borked, causing corruptions during
recovery. Effect limited to servers with 2PC, subtransactions and
recovery/replication.

Stas Kelvich, reviewed by Michael Paquier and Pavan Deolasee
This commit is contained in:
Simon Riggs 2016-09-09 13:11:25 +01:00
parent 1fa42debe6
commit 1fef3d576e
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/backend/access/transam/twophase.c
View File

@ -1758,8 +1758,9 @@ PrescanPreparedTransactions(TransactionId **xids_p, int *nxids_p)
* need to hold a lock while examining it. We still acquire the * need to hold a lock while examining it. We still acquire the
* lock to modify it, though. * lock to modify it, though.
*/ */
subxids = (TransactionId *) subxids = (TransactionId *) (buf +
(buf + MAXALIGN(sizeof(TwoPhaseFileHeader))); MAXALIGN(sizeof(TwoPhaseFileHeader)) +
MAXALIGN(hdr->gidlen));
for (i = 0; i < hdr->nsubxacts; i++) for (i = 0; i < hdr->nsubxacts; i++)
{ {
TransactionId subxid = subxids[i]; TransactionId subxid = subxids[i];
@ -1877,8 +1878,9 @@ StandbyRecoverPreparedTransactions(bool overwriteOK)
* Examine subtransaction XIDs ... they should all follow main * Examine subtransaction XIDs ... they should all follow main
* XID. * XID.
*/ */
subxids = (TransactionId *) subxids = (TransactionId *) (buf +
(buf + MAXALIGN(sizeof(TwoPhaseFileHeader))); MAXALIGN(sizeof(TwoPhaseFileHeader)) +
MAXALIGN(hdr->gidlen));
for (i = 0; i < hdr->nsubxacts; i++) for (i = 0; i < hdr->nsubxacts; i++)
{ {
TransactionId subxid = subxids[i]; TransactionId subxid = subxids[i];