database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-08-25 20:23:07 +03:00
Code Activity

expression eval: Don't redundantly keep track of AggState.

Browse Source 
It's already tracked via ExprState->parent, so we don't need to also
include it in ExprEvalStep. When that code originally was written
ExprState->parent didn't exist, but it since has been introduced in
6719b238e8.

Author: Andres Freund
Discussion: https://postgr.es/m/20191023163849.sosqbfs5yenocez3@alap3.anarazel.de
This commit is contained in:
Andres Freund
2020-02-06 19:06:16 -08:00
parent 1ec7679f1b
commit 1fdb7f9789
5 changed files with 20 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/include/executor/execExpr.h
View File

@@ -569,7 +569,6 @@ typedef struct ExprEvalStep
/* for EEOP_GROUPING_FUNC */
struct
{
AggState *parent; /* parent Agg */
List *clauses; /* integer list of column numbers */
} grouping_func;
@@ -597,7 +596,6 @@ typedef struct ExprEvalStep
/* for EEOP_AGG_*DESERIALIZE */
struct
{
AggState *aggstate;
FunctionCallInfo fcinfo_data;
int jumpnull;
} agg_deserialize;
@@ -625,7 +623,6 @@ typedef struct ExprEvalStep
/* for EEOP_AGG_INIT_TRANS */
struct
{
AggState *aggstate;
AggStatePerTrans pertrans;
ExprContext *aggcontext;
int setno;
@@ -637,7 +634,6 @@ typedef struct ExprEvalStep
/* for EEOP_AGG_STRICT_TRANS_CHECK */
struct
{
AggState *aggstate;
int setno;
int transno;
int setoff;
@@ -647,7 +643,6 @@ typedef struct ExprEvalStep
/* for EEOP_AGG_{PLAIN,ORDERED}_TRANS* */
struct
{
AggState *aggstate;
AggStatePerTrans pertrans;
ExprContext *aggcontext;
int setno;