diff --git a/src/backend/commands/view.c b/src/backend/commands/view.c index 67046752d30..ec0c90b42a2 100644 --- a/src/backend/commands/view.c +++ b/src/backend/commands/view.c @@ -111,11 +111,6 @@ DefineVirtualRelation(RangeVar *relation, List *tlist, bool replace, } } - if (attrList == NIL) - ereport(ERROR, - (errcode(ERRCODE_INVALID_TABLE_DEFINITION), - errmsg("view must have at least one column"))); - /* * Look up, check permissions on, and lock the creation namespace; also * check for a preexisting view with the same name. This will also set diff --git a/src/test/regress/expected/create_view.out b/src/test/regress/expected/create_view.out index e9a017fecb4..1434c2f85aa 100644 --- a/src/test/regress/expected/create_view.out +++ b/src/test/regress/expected/create_view.out @@ -20,6 +20,16 @@ COMMENT ON VIEW noview IS 'no view'; ERROR: relation "noview" does not exist COMMENT ON VIEW toyemp IS 'is a view'; COMMENT ON VIEW toyemp IS NULL; +-- These views are left around mainly to exercise special cases in pg_dump. +CREATE TABLE view_base_table (key int PRIMARY KEY, data varchar(20)); +CREATE VIEW key_dependent_view AS + SELECT * FROM view_base_table GROUP BY key; +ALTER TABLE view_base_table DROP CONSTRAINT view_base_table_pkey; -- fails +ERROR: cannot drop constraint view_base_table_pkey on table view_base_table because other objects depend on it +DETAIL: view key_dependent_view depends on constraint view_base_table_pkey on table view_base_table +HINT: Use DROP ... CASCADE to drop the dependent objects too. +CREATE VIEW key_dependent_view_no_cols AS + SELECT FROM view_base_table GROUP BY key HAVING length(data) > 0; -- -- CREATE OR REPLACE VIEW -- diff --git a/src/test/regress/expected/rules.out b/src/test/regress/expected/rules.out index 1971aa00637..eac3ee100ad 100644 --- a/src/test/regress/expected/rules.out +++ b/src/test/regress/expected/rules.out @@ -1289,6 +1289,14 @@ iexit| SELECT ih.name, FROM ihighway ih, ramp r WHERE (ih.thepath ## r.thepath); +key_dependent_view| SELECT view_base_table.key, + view_base_table.data + FROM view_base_table + GROUP BY view_base_table.key; +key_dependent_view_no_cols| SELECT + FROM view_base_table + GROUP BY view_base_table.key + HAVING (length((view_base_table.data)::text) > 0); mvtest_tv| SELECT mvtest_t.type, sum(mvtest_t.amt) AS totamt FROM mvtest_t diff --git a/src/test/regress/expected/sanity_check.out b/src/test/regress/expected/sanity_check.out index 5eb8b4af9b0..4930e6dc72d 100644 --- a/src/test/regress/expected/sanity_check.out +++ b/src/test/regress/expected/sanity_check.out @@ -172,6 +172,7 @@ timestamp_tbl|f timestamptz_tbl|f timetz_tbl|f varchar_tbl|f +view_base_table|t -- restore normal output mode \a\t -- diff --git a/src/test/regress/sql/create_view.sql b/src/test/regress/sql/create_view.sql index 8a365749fce..11f539fcd36 100644 --- a/src/test/regress/sql/create_view.sql +++ b/src/test/regress/sql/create_view.sql @@ -24,6 +24,18 @@ COMMENT ON VIEW noview IS 'no view'; COMMENT ON VIEW toyemp IS 'is a view'; COMMENT ON VIEW toyemp IS NULL; +-- These views are left around mainly to exercise special cases in pg_dump. + +CREATE TABLE view_base_table (key int PRIMARY KEY, data varchar(20)); + +CREATE VIEW key_dependent_view AS + SELECT * FROM view_base_table GROUP BY key; + +ALTER TABLE view_base_table DROP CONSTRAINT view_base_table_pkey; -- fails + +CREATE VIEW key_dependent_view_no_cols AS + SELECT FROM view_base_table GROUP BY key HAVING length(data) > 0; + -- -- CREATE OR REPLACE VIEW --