From 1eda3ce80287f985f8165640d4bf663fe4649b41 Mon Sep 17 00:00:00 2001 From: Jeff Davis Date: Tue, 15 Nov 2022 15:58:12 -0800 Subject: [PATCH] Mark argument of RegisterCustomRmgr() as const. --- doc/src/sgml/custom-rmgr.sgml | 2 +- src/backend/access/transam/rmgr.c | 2 +- src/include/access/xlog_internal.h | 2 +- src/test/modules/test_custom_rmgrs/test_custom_rmgrs.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/doc/src/sgml/custom-rmgr.sgml b/doc/src/sgml/custom-rmgr.sgml index 6d6909fc128..baf86b1c07d 100644 --- a/doc/src/sgml/custom-rmgr.sgml +++ b/doc/src/sgml/custom-rmgr.sgml @@ -78,7 +78,7 @@ typedef struct RmgrData * developers. During development, use RM_EXPERIMENTAL_ID to avoid needlessly * reserving a new ID. */ -extern void RegisterCustomRmgr(RmgrId rmid, RmgrData *rmgr); +extern void RegisterCustomRmgr(RmgrId rmid, const RmgrData *rmgr); RegisterCustomRmgr must be called from the extension module's _PG_init function. diff --git a/src/backend/access/transam/rmgr.c b/src/backend/access/transam/rmgr.c index 6bb4de387f3..7d67eda5f79 100644 --- a/src/backend/access/transam/rmgr.c +++ b/src/backend/access/transam/rmgr.c @@ -95,7 +95,7 @@ RmgrNotFound(RmgrId rmid) * reserving a new ID. */ void -RegisterCustomRmgr(RmgrId rmid, RmgrData *rmgr) +RegisterCustomRmgr(RmgrId rmid, const RmgrData *rmgr) { if (rmgr->rm_name == NULL || strlen(rmgr->rm_name) == 0) ereport(ERROR, (errmsg("custom resource manager name is invalid"), diff --git a/src/include/access/xlog_internal.h b/src/include/access/xlog_internal.h index 6a721eb3f3e..e5fc66966bc 100644 --- a/src/include/access/xlog_internal.h +++ b/src/include/access/xlog_internal.h @@ -362,7 +362,7 @@ extern PGDLLIMPORT RmgrData RmgrTable[]; extern void RmgrStartup(void); extern void RmgrCleanup(void); extern void RmgrNotFound(RmgrId rmid); -extern void RegisterCustomRmgr(RmgrId rmid, RmgrData *rmgr); +extern void RegisterCustomRmgr(RmgrId rmid, const RmgrData *rmgr); #ifndef FRONTEND static inline bool diff --git a/src/test/modules/test_custom_rmgrs/test_custom_rmgrs.c b/src/test/modules/test_custom_rmgrs/test_custom_rmgrs.c index 6e5270bf839..d8e513ae931 100644 --- a/src/test/modules/test_custom_rmgrs/test_custom_rmgrs.c +++ b/src/test/modules/test_custom_rmgrs/test_custom_rmgrs.c @@ -51,7 +51,7 @@ void testcustomrmgrs_redo(XLogReaderState *record); void testcustomrmgrs_desc(StringInfo buf, XLogReaderState *record); const char *testcustomrmgrs_identify(uint8 info); -static RmgrData testcustomrmgrs_rmgr = { +static const RmgrData testcustomrmgrs_rmgr = { .rm_name = TESTCUSTOMRMGRS_NAME, .rm_redo = testcustomrmgrs_redo, .rm_desc = testcustomrmgrs_desc,