mirror of
https://github.com/postgres/postgres.git
synced 2025-11-06 07:49:08 +03:00
Re-allow using statistics for bool-valued functions in WHERE.
Commita391ff3c3, which added the ability for a function's support function to provide a custom selectivity estimate for "WHERE f(...)", unintentionally removed the possibility of applying expression statistics after finding there's no applicable support function. That happened because we no longer fell through to boolvarsel() as before. Refactor to do so again, putting the 0.3333333 default back into boolvarsel() where it had been (cf. commit39df0f150). I surely wouldn't have made this error if39df0f150had included a test case, so add one now. At the time we did not have the "extended statistics" infrastructure, but we do now, and it is also unable to work in this scenario because of this error. So make use of that for the test case. This is very clearly a bug fix, but I'm afraid to put it into released branches because of the likelihood of altering plan choices, which we avoid doing in minor releases. So, master only. Reported-by: Frédéric Yhuel <frederic.yhuel@dalibo.com> Author: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://postgr.es/m/a8b99dce-1bfb-4d97-af73-54a32b85c916@dalibo.com
This commit is contained in:
@@ -1528,6 +1528,17 @@ boolvarsel(PlannerInfo *root, Node *arg, int varRelid)
|
||||
selec = var_eq_const(&vardata, BooleanEqualOperator, InvalidOid,
|
||||
BoolGetDatum(true), false, true, false);
|
||||
}
|
||||
else if (is_funcclause(arg))
|
||||
{
|
||||
/*
|
||||
* If we have no stats and it's a function call, estimate 0.3333333.
|
||||
* This seems a pretty unprincipled choice, but Postgres has been
|
||||
* using that estimate for function calls since 1992. The hoariness
|
||||
* of this behavior suggests that we should not be in too much hurry
|
||||
* to use another value.
|
||||
*/
|
||||
selec = 0.3333333;
|
||||
}
|
||||
else
|
||||
{
|
||||
/* Otherwise, the default estimate is 0.5 */
|
||||
|
||||
Reference in New Issue
Block a user