database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-21 16:02:15 +03:00
Code Activity

Don't try to remove duplicate OR-subclauses in create_bitmap_subplan and

Browse Source 
make_restrictinfo_from_bitmapqual.  The likelihood of finding duplicates
seems much less than in the AND-subclause case, and the cost much higher,
because OR lists with hundreds or even thousands of subclauses are not
uncommon.  Per discussion with Ilia Kantor and andrew@supernews.
This commit is contained in:
Tom Lane
2005-10-13 00:06:46 +00:00
parent 23e2f9ebf7
commit 1e9a6ba5e6
2 changed files with 24 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
src/backend/optimizer/plan/createplan.c
View File

@ -10,7 +10,7 @@
* *
* *
* IDENTIFICATION * IDENTIFICATION
* $PostgreSQL: pgsql/src/backend/optimizer/plan/createplan.c,v 1.199 2005/10/06 16:01:54 tgl Exp $ * $PostgreSQL: pgsql/src/backend/optimizer/plan/createplan.c,v 1.200 2005/10/13 00:06:46 tgl Exp $
* *
*------------------------------------------------------------------------- *-------------------------------------------------------------------------
*/ */
@ -1046,9 +1046,13 @@ create_bitmap_subplan(PlannerInfo *root, Path *bitmapqual,
ListCell *l; ListCell *l;
/* /*
* Here, we detect both obvious redundancies and qual-free subplans. * Here, we only detect qual-free subplans. A qual-free subplan would
* A qual-free subplan would cause us to generate "... OR true ..." * cause us to generate "... OR true ..." which we may as well reduce
* which we may as well reduce to just "true". * to just "true". We do not try to eliminate redundant subclauses
* because (a) it's not as likely as in the AND case, and (b) we might
* well be working with hundreds or even thousands of OR conditions,
* perhaps from a long IN list. The performance of list_append_unique
* would be unacceptable.
*/ */
foreach(l, opath->bitmapquals) foreach(l, opath->bitmapquals)
{ {
@ -1062,13 +1066,13 @@ create_bitmap_subplan(PlannerInfo *root, Path *bitmapqual,
if (subqual == NIL) if (subqual == NIL)
const_true_subqual = true; const_true_subqual = true;
else if (!const_true_subqual) else if (!const_true_subqual)
subquals = list_append_unique(subquals, subquals = lappend(subquals,
make_ands_explicit(subqual)); make_ands_explicit(subqual));
if (subindexqual == NIL) if (subindexqual == NIL)
const_true_subindexqual = true; const_true_subindexqual = true;
else if (!const_true_subindexqual) else if (!const_true_subindexqual)
subindexquals = list_append_unique(subindexquals, subindexquals = lappend(subindexquals,
make_ands_explicit(subindexqual)); make_ands_explicit(subindexqual));
} }
plan = (Plan *) make_bitmap_or(subplans); plan = (Plan *) make_bitmap_or(subplans);
plan->startup_cost = opath->path.startup_cost; plan->startup_cost = opath->path.startup_cost;

20
src/backend/optimizer/util/restrictinfo.c
View File

@ -8,7 +8,7 @@
* *
* *
* IDENTIFICATION * IDENTIFICATION
* $PostgreSQL: pgsql/src/backend/optimizer/util/restrictinfo.c,v 1.39 2005/07/28 20:26:21 tgl Exp $ * $PostgreSQL: pgsql/src/backend/optimizer/util/restrictinfo.c,v 1.40 2005/10/13 00:06:46 tgl Exp $
* *
*------------------------------------------------------------------------- *-------------------------------------------------------------------------
*/ */
@ -123,9 +123,13 @@ make_restrictinfo_from_bitmapqual(Path *bitmapqual,
List *withoutris = NIL; List *withoutris = NIL;
/* /*
* Here, we detect both obvious redundancies and qual-free subplans. * Here, we only detect qual-free subplans. A qual-free subplan would
* A qual-free subplan would cause us to generate "... OR true ..." * cause us to generate "... OR true ..." which we may as well reduce
* which we may as well reduce to just "true". * to just "true". We do not try to eliminate redundant subclauses
* because (a) it's not as likely as in the AND case, and (b) we might
* well be working with hundreds or even thousands of OR conditions,
* perhaps from a long IN list. The performance of list_append_unique
* would be unacceptable.
*/ */
foreach(l, opath->bitmapquals) foreach(l, opath->bitmapquals)
{ {
@ -144,12 +148,12 @@ make_restrictinfo_from_bitmapqual(Path *bitmapqual,
return NIL; return NIL;
} }
/* Create AND subclause with RestrictInfos */ /* Create AND subclause with RestrictInfos */
withris = list_append_unique(withris, withris = lappend(withris,
make_ands_explicit(sublist)); make_ands_explicit(sublist));
/* And one without */ /* And one without */
sublist = get_actual_clauses(sublist); sublist = get_actual_clauses(sublist);
withoutris = list_append_unique(withoutris, withoutris = lappend(withoutris,
make_ands_explicit(sublist)); make_ands_explicit(sublist));
} }
/* /*