mirror of
https://github.com/postgres/postgres.git
synced 2025-07-31 22:04:40 +03:00
Try to deliver a sane message for _create_locale() failure on Windows.
We were just printing errno, which is certainly not gonna work on Windows. Now, it's not entirely clear from Microsoft's documentation whether _create_locale() adheres to standard Windows error reporting conventions, but let's assume it does and try to map the GetLastError result to an errno. If this turns out not to work, probably the best thing to do will be to assume the error is always ENOENT on Windows. This is a longstanding bug, but given the lack of previous field complaints, I'm not excited about back-patching it. Per report from Murtuza Zabuawala. Discussion: https://postgr.es/m/CAKKotZS-wcDcofXDCH=sidiuajE+nqHn2CGjLLX78anyDmi3gQ@mail.gmail.com
This commit is contained in:
@ -1227,13 +1227,18 @@ lc_ctype_is_c(Oid collation)
|
||||
static void
|
||||
report_newlocale_failure(const char *localename)
|
||||
{
|
||||
/* copy errno in case one of the ereport auxiliary functions changes it */
|
||||
int save_errno = errno;
|
||||
int save_errno;
|
||||
|
||||
/* On Windows, transform _create_locale() error to errno */
|
||||
#ifdef WIN32
|
||||
_dosmaperr(GetLastError());
|
||||
#endif
|
||||
|
||||
/*
|
||||
* ENOENT means "no such locale", not "no such file", so clarify that
|
||||
* errno with an errdetail message.
|
||||
*/
|
||||
save_errno = errno; /* auxiliary funcs might change errno */
|
||||
ereport(ERROR,
|
||||
(errcode(ERRCODE_INVALID_PARAMETER_VALUE),
|
||||
errmsg("could not create locale \"%s\": %m",
|
||||
|
Reference in New Issue
Block a user