database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-11-10 17:42:29 +03:00
Code Activity

Further code and wording tweaks in BRIN

Browse Source 
Besides a couple of typo fixes, per David Rowley, Thom Brown, and Amit
Langote, and mentions of BRIN in the general CREATE INDEX page again per
David, this includes silencing MSVC compiler warnings (thanks Microsoft)
and an additional variable initialization per Coverity scanner.
This commit is contained in:
Alvaro Herrera
2014-11-10 15:56:08 -03:00
parent 96a73fcdac
commit 1e0b4365c2
5 changed files with 13 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
doc/src/sgml/brin.sgml
View File

@@ -64,7 +64,7 @@
<title>Built-in Operator Classes</title> <title>Built-in Operator Classes</title>
<para> <para>
The core <productname>PostgreSQL</productname> distribution includes The core <productname>PostgreSQL</productname> distribution
includes the <acronym>BRIN</acronym> operator classes shown in includes the <acronym>BRIN</acronym> operator classes shown in
<xref linkend="brin-builtin-opclasses-table">. <xref linkend="brin-builtin-opclasses-table">.
</para> </para>

9
doc/src/sgml/ref/create_index.sgml
View File

@@ -57,8 +57,8 @@ CREATE [ UNIQUE ] INDEX [ CONCURRENTLY ] [ [ IF NOT EXISTS ] <replaceable class=
<para> <para>
<productname>PostgreSQL</productname> provides the index methods <productname>PostgreSQL</productname> provides the index methods
B-tree, hash, GiST, SP-GiST, and GIN. Users can also define their own index B-tree, hash, GiST, SP-GiST, GIN, and BRIN. Users can also define their own
methods, but that is fairly complicated. index methods, but that is fairly complicated.
</para> </para>
<para> <para>
@@ -166,7 +166,8 @@ CREATE [ UNIQUE ] INDEX [ CONCURRENTLY ] [ [ IF NOT EXISTS ] <replaceable class=
<para> <para>
The name of the index method to be used. Choices are The name of the index method to be used. Choices are
<literal>btree</literal>, <literal>hash</literal>, <literal>btree</literal>, <literal>hash</literal>,
<literal>gist</literal>, <literal>spgist</> and <literal>gin</>. <literal>gist</literal>, <literal>spgist</>, <literal>gin</>, and
<literal>brin</>.
The default method is <literal>btree</literal>. The default method is <literal>btree</literal>.
</para> </para>
</listitem> </listitem>
@@ -492,7 +493,7 @@ Indexes:
</caution> </caution>
<para> <para>
Currently, only the B-tree, GiST and GIN index methods support Currently, only the B-tree, GiST, GIN, and BRIN index methods support
multicolumn indexes. Up to 32 fields can be specified by default. multicolumn indexes. Up to 32 fields can be specified by default.
(This limit can be altered when building (This limit can be altered when building
<productname>PostgreSQL</productname>.) Only B-tree currently <productname>PostgreSQL</productname>.) Only B-tree currently

2
src/backend/access/brin/README
View File

@@ -126,7 +126,7 @@ that page range is complete and new tuples belong in a new page range that
hasn't yet been summarized. Those insertions do not create a new index hasn't yet been summarized. Those insertions do not create a new index
entry; instead, the page range remains unsummarized until later. entry; instead, the page range remains unsummarized until later.
Wehn VACUUM is run on the table, all unsummarized page ranges are Whenever VACUUM is run on the table, all unsummarized page ranges are
summarized. This action can also be invoked by the user via summarized. This action can also be invoked by the user via
brin_summarize_new_values(). Both these procedures scan all the brin_summarize_new_values(). Both these procedures scan all the
unsummarized ranges, and create a summary tuple. Again, this includes the unsummarized ranges, and create a summary tuple. Again, this includes the

8
src/backend/access/brin/brin.c
View File

@@ -107,9 +107,11 @@ brininsert(PG_FUNCTION_ARGS)
BrinMemTuple *dtup; BrinMemTuple *dtup;
BlockNumber heapBlk; BlockNumber heapBlk;
int keyno; int keyno;
BrinTuple *tmptup PG_USED_FOR_ASSERTS_ONLY; #ifdef USE_ASSERT_CHECKING
BrinMemTuple *tmpdtup PG_USED_FOR_ASSERTS_ONLY; BrinTuple *tmptup;
Size tmpsiz PG_USED_FOR_ASSERTS_ONLY; BrinMemTuple *tmpdtup;
Size tmpsiz;
#endif
CHECK_FOR_INTERRUPTS(); CHECK_FOR_INTERRUPTS();

2
src/backend/access/brin/brin_tuple.c
View File

@@ -95,7 +95,7 @@ brin_form_tuple(BrinDesc *brdesc, BlockNumber blkno, BrinMemTuple *tuple,
BrinTuple *rettuple; BrinTuple *rettuple;
int keyno; int keyno;
int idxattno; int idxattno;
uint16 phony_infomask; uint16 phony_infomask = 0;
bits8 *phony_nullbitmap; bits8 *phony_nullbitmap;
Size len, Size len,
hoff, hoff,